fix(#301): Handle JSONStream.parse() errors more gracefully #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnturner
force-pushed
the
error-handling
branch
from
ced6da4
to
2e38b3b
Compare
quinnturner
commented
Jan 13, 2023
| .pipe(JSONStream.parse()) | ||
| .pipe( | ||
| transform.on("error", (error) => { | ||
| throw error; |
There was a problem hiding this comment.
This wasn't strictly necessary, but it did convert an error location from within node:stream to this userland function.
| proc.on("error", (error) => reject(error)); | ||
| proc.on("close", () => { | ||
| if (errorMessage) { | ||
| return reject(new Error(errorMessage)); |
There was a problem hiding this comment.
Here's the error:
➜ node ../../dist/bin.js
audit-ci version: 6.5.0
Yarn Berry audit report results:
node:events:491
throw er; // Unhandled 'error' event
^
Error: Internal Error: audit-ci-yarn-workspace@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile
at Stream.<anonymous> (/Users/quinn/Dev/quinnturner/audit-ci/dist/common.js:132:15)
at Stream.emit (node:events:525:35)
at parser.onError (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/JSONStream/index.js:142:12)
at proto.charError (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/jsonparse/jsonparse.js:90:8)
at proto.write (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/jsonparse/jsonparse.js:154:23)
at Stream.<anonymous> (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/JSONStream/index.js:23:12)
at stream.write (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/through/index.js:26:11)
at Stream.ondata (node:internal/streams/legacy:20:31)
at Stream.emit (node:events:513:28)
at Stream.write (/Users/quinn/Dev/quinnturner/audit-ci/node_modules/event-stream/index.js:210:12)
Emitted 'error' event on ReadlineTransform instance at:
at ReadlineTransform.onerror (node:internal/streams/readable:785:14)
at ReadlineTransform.emit (node:events:513:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Node.js v19.3.0
I wouldn't say this is the cleanest error of all time, but it is much better than a JSONStream.parse() error!
Signed-off-by: Quinn Turner <quinnturnertech@gmail.com>
quinnturner
force-pushed
the
error-handling
branch
from
2e38b3b
to
4bdaf5b
Compare
andy-patt
approved these changes
Jan 19, 2023
This was referenced Jan 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.