fix(runNpmAudit): Replace error checking from stderr to error #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnturner
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
LGTM, thanks! We are considering migrating to using spawn instead of exec (related: #47 #48). We could release this as a temporary fix or just do the migration immediately. @andy-patt thoughts?
andy-patt
approved these changes
Feb 7, 2019
| } | ||
|
|
||
| const parsedAudit = JSON.parse(stdout); | ||
| callback(null, parsedAudit); | ||
| if (_error) { |
There was a problem hiding this comment.
I'd guess that this variable should be named just error now that it's being used.
This is just nit-picking though; fine to merge as-is.
There was a problem hiding this comment.
I didn't want to be so invasive with the PR, but I agree with it
|
@quinnturner It seems like this is an improvement to the status-quo so I'd be in favour of merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: Bug fixing
Does this introduce a breaking change?: No
Problem description
This pull request tackles down the issue #49
Solution description
If something was returned to the output stream, it should be a formatted json, and it tries to parse it. In case there are issues with the output (couldn't parse the JSON) it will return an error.
If the output is empty will check for errors.
Note: You may want to move the
if (_error)to the top, but the current approach is more optimistic and relays on the output and the output JSON.Side Effects
N/A
Additional comments
Tested on node.js v10.15.1 and npm v6.5.0