Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename resources folder to bundleParts #152

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Rename resources folder to bundleParts #152

merged 1 commit into from
Jul 21, 2020

Conversation

sophiegreen
Copy link
Contributor

Signed-off-by: Sophie Green sophiegr@uk.ibm.com

@sophiegreen
Rename resources folder to bundleParts
10e9f68 
Signed-off-by: Sophie Green <sophiegr@uk.ibm.com>
@tom-foyle tom-foyle self-requested a review July 21, 2020 10:11
tom-foyle
tom-foyle approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@tom-foyle tom-foyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Gradle plugin the bundleParts directory is configurable in case the user wanted to use a different location for whatever reason. Might be nice if Maven did the same, but probably not crucially important.

@sophiegreen
Copy link
Contributor Author

In the Gradle plugin the bundleParts directory is configurable in case the user wanted to use a different location for whatever reason. Might be nice if Maven did the same, but probably not crucially important.

Interesting, thanks. I'll take a look at how the user configures that for Gradle and see if it makes sense to do something similar for Maven.

@sophiegreen sophiegreen merged commit be21e93 into IBM:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-foyle tom-foyle tom-foyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiegreen @tom-foyle