Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixing on environment setup #1

Merged
merged 3 commits into from
Jan 31, 2018
Merged

minor fixing on environment setup #1

merged 3 commits into from
Jan 31, 2018

Conversation

fengggli
Copy link
Collaborator

@fengggli fengggli commented Nov 16, 2017

Hi Daniel,
I got the chance to deploy Comanche to my workstation recently. I spent some time negotiating with the Department to get the full root access to it...
Some suggestions:

  1. uuid-dev is required by spdk (/uuid/uuid.h)
  2. the change in src/lib/core/CMakeLists.txt is for out-of-tree build
  3. I also maintained a wiki on configuring qemu with nvme support with libvirt in my fork (https://github.com/fengggli/comanche/wiki/vm). Hope it's also useful for other collaborators.
    Thanks

@dwaddington dwaddington merged commit 5f1d55f into IBM:unstable Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants