Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildfix #7

Merged
merged 7 commits into from
May 17, 2018
Merged

Buildfix #7

merged 7 commits into from
May 17, 2018

Conversation

fengggli
Copy link
Collaborator

@fengggli fengggli commented May 17, 2018

Major changes

  1. now force out-of-tree build, see the updated README.md
  2. add 'make install' support, after make install, all the .so will be in /build/install/lib. the common/component.cc will also load from that directory.

Minor changes

  1. removed all the env(COMANCHE_HOME) in c/c++ source code, the COMANCHE_HOME is now set in the root CMakeLists.txt, and then auto-populated to the config_comanche.h during cmake (see config_comanche.h.in)
  2. autogen.py and cmakeinclude are removed, they were intrusive to the source tree.. If we need slightly modify the source code, it's better done by config_comanche.h
  3. fix: nvme_set reset support
  4. add required entries for install-apts.sh

Note

  • I temporarily disabled the build for "cluster"
  • you need to rerun the install-apts.sh to add required packages

@dwaddington dwaddington merged commit 2969917 into IBM:unstable May 17, 2018
@fengggli fengggli deleted the buildfix branch May 17, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants