Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a controller and custom uploader #3

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

takeshi-yoshimura
Copy link
Member

Hi @No9,
This is our operator to support multiple users with buckets per namespace.
The code change might be too large to be merged immediately, but we can separate this later if we need to do so.

This PR adds two new components written in Golang.

  • Uploader for multiple users: cmd/core-dump-uploader
  • Controller: controllers and api/v1alpha1.

This also modifies CRD. See the generated .yaml file config/crd/bases/charts.ibm.com_coredumphandlers.yaml.

The controller is a re-implementation of what the helm chart did roughly. It deploys a daemonset with a pod running the new uploader and core-dump-agent.

@No9
Copy link
Contributor

No9 commented Aug 22, 2023

Thanks @takeshi-yoshimura
As per the repo check can you sign the commit with a DCO.
Also as we have access to worflows here are there any tests that we can run on a commit to validate updates?

@No9 No9 self-requested a review August 22, 2023 13:27
Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
@takeshi-yoshimura
Copy link
Member Author

@No9
I added a sign-off. thanks.

You can run make uploader-test and make operator-test (go is required). But operator tests are not implemented yet. It just returns 0% coverage now. I will incrementally add tests later.

Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
@takeshi-yoshimura
Copy link
Member Author

I added workflows for unit tests and image builds. I also set the required secrets in this repo so that we can start workflows after the code is merged into the master branch. thanks.

This was referenced Aug 23, 2023
@No9 No9 merged commit ff09717 into IBM:master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants