Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super pipeline generator #233

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Conversation

Mohammad-nassar10
Copy link
Collaborator

@Mohammad-nassar10 Mohammad-nassar10 commented Jun 5, 2024

Why are these changes needed?

Add a tool that helps to generate super pipelines python code.

Related issue number (if any).

Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
@Mohammad-nassar10 Mohammad-nassar10 marked this pull request as draft June 5, 2024 06:56
@Mohammad-nassar10 Mohammad-nassar10 marked this pull request as ready for review June 5, 2024 08:11
@Mohammad-nassar10 Mohammad-nassar10 marked this pull request as draft June 5, 2024 08:31
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
@Mohammad-nassar10 Mohammad-nassar10 changed the title Super pipe gene Super pipeline generator Jun 5, 2024
Mohammad-nassar10 and others added 2 commits July 16, 2024 14:35
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
@Mohammad-nassar10 Mohammad-nassar10 marked this pull request as ready for review July 17, 2024 13:14
@blublinsky
Copy link
Collaborator

@Mohammad-nassar10, @revit13, @roytman is this still relevant? It has been dormant for a while

@Mohammad-nassar10
Copy link
Collaborator Author

@blublinsky yes, I updated in the past two days.

@@ -0,0 +1,6 @@
## Steps to generate a new super pipeline in KFP v1.
- The super pipeline is a way to execute several transforms with one pipeline. You can find more details in [multi_transform_pipeline.md](../../doc/multi_transform_pipeline.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restrict line length to 80 characters:

How about the following explanation ?

  • The super pipeline allows you to execute several transforms within a single pipeline. For more details, refer to multi_transform_pipeline.md
  • Create a super_pipeline_definitions.yaml file for the required task. You can refer to the example super_pipeline_definitions.yaml.
  • Execute ./run.sh < super_pipeline_definitions.yaml> <destination_directory>. Here, super_pipeline_definitions.yaml is the super pipeline definition file, that you created above, and destination_directory is the directory where the new super pipeline file will be generated.

Note: The component_spec_path is the path to the kfp_ray_components folder and depends on where the workflow is compiled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we set component_spec_path ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Readme.md updated.
The user can set the component_spec_path in the super_pipeline_definitions.yaml.

@@ -0,0 +1,11 @@
#!/bin/bash

DEF_FILE=$1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you take examples of arguments processing from run.sh in the single pipeline generator

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the implementation to use jinja as in the single pipeline generator.

Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roytman roytman merged commit 4e3e8e9 into IBM:dev Jul 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants