fix s3 sample data input path (again) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wood <dawood@us.ibm.com>
blublinsky
approved these changes
May 2, 2024
| @@ -242,7 +242,7 @@ conventions: | |||
| .transforms.minio-load:: | |||
| @# Help: Install the test-data/input files into minio for $(TRANSFORM_NAME) | |||
| dir=$$(find $(REPOROOT)/transforms -type d -name $(TRANSFORM_NAME)); \ | |||
| $(MAKE) MINIO_SRC=$$dir/test-data/input MINIO_DEST=$(TRANSFORM_NAME)/input/ .defaults.minio.load-test-data | |||
| $(MAKE) MINIO_SRC=$$dir/test-data/input MINIO_DEST=$(TRANSFORM_NAME)/ .defaults.minio.load-test-data | |||
There was a problem hiding this comment.
My suggestion is to do
$(MAKE) MINIO_SRC=$$dir/test-data/input/ MINIO_DEST=$(TRANSFORM_NAME)/input .defaults.minio.load-test-data
They both work. The difference is that in your implementation moves the folder, while in what I am suggesting its moving the content of the folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number (if any).