First drop of samples from 11.5.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qpresley
approved these changes
Jul 20, 2019
There was a problem hiding this comment.
Wow, nicely done. I'm not going to check to verify every file is correct .. I'll take your word for it. One comment though, we may want to check with legal to see if they want all the files to have the Apache 2.0 prologue such that these match the Repo LICENSE file. I'm not sure it is a big deal as the prologue doesn't call out a specific library but it may be good for consistency.
irinadel
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the full set of samples from an 11.5.0 (Docker) installation, as-is.