Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Remove any hardcoded strings in Docker and deployment files #6

Open
cmluciano opened this issue Mar 20, 2018 · 2 comments
Open

Remove any hardcoded strings in Docker and deployment files #6

cmluciano opened this issue Mar 20, 2018 · 2 comments

Comments

@cmluciano
Copy link

Most of the files have hardcoded docker and infrastructure strings. These need to be removed in favor of a script that accepts variables.
@MHBauer
Copy link
Contributor

MHBauer commented Mar 27, 2018

Which specific strings?

@cmluciano
Copy link
Author

hardcoded variables that can probably be reverted to using env vars
use env vars instead of needing to pass the whole sting
ideally a root Makefile or script can auto-fill these based on env var

DevOpsBot1 pushed a commit to open-toolchain/guestbook that referenced this issue Dec 9, 2021
@huayuenh
chore: build fix canary (IBM#6)
94d990f 
chore: build fix
chore: add limits
chore: set resource limits
chore: add exemption
chore: switch to minimal ubi image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmluciano @MHBauer