Expose up metric as part of systemInfo metrics #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tal Yichye <tal.yichye@ibm.com>
bvered
approved these changes
Sep 8, 2022
bvered
added a commit
that referenced
this pull request
Feb 1, 2023
* update release version * Update go.mod * update release version * add logical capacity calcs for all pools and refactor collectPoolMetrics function Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * add physical metrics for child pools Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * Fix storagesystem physical calc (#36) * add system physical capacity usage Signed-off-by: Vered Berenstein Paz <BVERED@il.ibm.com> * Bump version to 1.3.0 Change driver version to 1.3.0. Signed-off-by: 662962756 <bvered@il.ibm.com> * action: changes to go.mod and go.sum files do not inflict problems to… (#42) * action: changes to go.mod and go.sum files do not inflict problems to the build Signed-off-by: Alon Firestein <alon.firestein@ibm.com> * Add support for multiple StorageSystems (#43) * add support for multiple storagesystems * add Copyright header to new files * add updated operator version tag to go.mod * fix log error prints * fix false-positive golangci issue * Collect pools metrics only if pool exist & Update storage credentials when needed (#44) * update storage credentials upon secret change * disable commitlint github action Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * Task/change warning threashold label (#45) * change warning capacity label * fix lssystem parsing * fix test * fix gosum and usage in operators function * fix logging Signed-off-by: Vered Berenstein <bvered@il.ibm.com> * fix capacity calcs (#46) * fix physical system and pool capacity calculations by adding reclaimable size * fix go mod * remove error var * fix gosum * remove non-exposed value. * Improve test Signed-off-by: 662962756 <bvered@il.ibm.com> * Handle errors with os.exit() instead of goto command (#47) * handle errors with os.exit instead of goto command * remove todos and stop collect capacity metrics in case of an error Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * expose up metric as part of systemInfo metrics (#49) Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * fix shared pointer bug (#50) Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * upgrade prometheus client golang version to 1.13.0 (#51) Signed-off-by: 662962756 <bvered@il.ibm.com> * Add unit tests for multiple storage support metrics collection (#52) * add unit tests for multiple storage support metrics collection * add unit test for system capacity metrics Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * check client state on existing manager (#53) * check client state on existing manager Signed-off-by: 662962756 <bvered@il.ibm.com> * update fsc status only if different from current status (#54) Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * upgrade go and sub-packages versions Signed-off-by: 662962756 <bvered@il.ibm.com> * fix SA1019: "io/ioutil" has been deprecated since Go 1.16 Signed-off-by: 662962756 <bvered@il.ibm.com> * add unitests for rest module Signed-off-by: 662962756 <bvered@il.ibm.com> * add unitests for rest module Signed-off-by: 662962756 <bvered@il.ibm.com> * add unitests for rest module Signed-off-by: 662962756 <bvered@il.ibm.com> * add unitests for rest module Signed-off-by: 662962756 <bvered@il.ibm.com> * Update operator go mod version (#57) * update operator tag for go mod file * upgrade operator latest version Signed-off-by: 662962756 <bvered@il.ibm.com> * Calc physical and logical pool capacities by fixing reclaimable capacity calculations (#60) * Calc physical and logical pool capacities by fixing reclaimable capacity calculations * Calc physical storage capacity by fixing reclaimable calculation per pool * Error: S1002: should omit comparison to bool constant, can be simplified * fix tests * check if pool mdisks are compressed * check if pool mdisks are compressed * add a test section to calc reclamation for non-compressed drives * revert files * remove reclaimable-0 in case of external storage * rename variables * fix test * fix calculation * remove child-pool calc Signed-off-by: 662962756 <bvered@il.ibm.com> * Task/add warning for external stg (#61) * chedck if pool has external disks * check if storage has any external pool * fix test * expose external functions * Reduce usage of -isInternalStorage function * create PoolInfo data in flashsystem * add Mdisks list into Pool data * return from Collect in case of error * add compression data for poolInfo * refactor vars and functions names Signed-off-by: 662962756 <bvered@il.ibm.com> Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * Docs release 1.3.0 (#58) * update operator tag for go mod file * upgrade operator latest version * Create configuring.dita * separated out limitations * updated naming * updated link * sorted into folders * added basic files for ibm docs * added trademark info * added related publications * Create configuring.dita * separated out limitations * updated naming * updated link * sorted into folders * added no translate rules * updated link to matrix page * updated welcome name * updated linking * updated what's new title * adding what's new info per Alon * added installing info * updated to show that it is new support * reworded for general support - not display specific * added breadcrumbs to installation * placed matrix in toc * fixed matrix linking * updated installation instructions per RM * updated typo in link * Update docs_whatsnew.dita * change docker.io/ibmcom to quay.io/ibmodffs (#62) * change docker.io/ibmcom to quay.io/ibmodffs * remove hub Signed-off-by: 662962756 <bvered@il.ibm.com> * change operator to 1.3.0 tag (#63) Signed-off-by: 662962756 <bvered@il.ibm.com> * Update docs_whatsnew.dita Signed-off-by: Vered Berenstein <bvered@il.ibm.com> --------- Signed-off-by: Tal Yichye <tal.yichye@ibm.com> Signed-off-by: Vered Berenstein Paz <BVERED@il.ibm.com> Signed-off-by: 662962756 <bvered@il.ibm.com> Signed-off-by: Alon Firestein <alon.firestein@ibm.com> Signed-off-by: Vered Berenstein <bvered@il.ibm.com> Co-authored-by: Tal Yichye <tal.yichye@ibm.com> Co-authored-by: Alon Firestein <57404551+alonfirestein@users.noreply.github.com> Co-authored-by: tyichye19 <84450119+tyichye19@users.noreply.github.com> Co-authored-by: rivkap <54570654+rivkap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tal Yichye tal.yichye@ibm.com