feat(CloudPakForDataServiceInstanceAuthenticator): add new cp4d service instance authenticator #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new authenticator implementation that supports the "GET /zen-data/v3/service_instances/serviceInstanceId/token" operation which is part of the Cloud Pak For Data authentication service. This allows users to obtain access tokens for service instances using the username, apikey, and service instance id in CP4D.
padamstx
suggested changes
Nov 17, 2021
There was a problem hiding this comment.
Outstanding job on this PR! In addition to the things we discussed on webex, I requested a few small changes that are mostly just cosmetic, plus I think you have a handful of duplicated testcases (probably due to the fact that other authenticators need to continue to test the legacy ctor, etc.).
src/main/java/com/ibm/cloud/sdk/core/security/CloudPakForDataServiceInstanceAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloud/sdk/core/security/CloudPakForDataServiceInstanceAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloud/sdk/core/security/CloudPakForDataServiceInstanceAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloud/sdk/core/security/CloudPakForDataServiceInstanceAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloud/sdk/core/security/CloudPakForDataServiceInstanceAuthenticator.java
Outdated
Show resolved
Hide resolved
...test/java/com/ibm/cloud/sdk/core/test/security/Cp4dServiceInstanceAuthenticatorLiveTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ibm/cloud/sdk/core/test/security/Cp4dServiceInstanceAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ibm/cloud/sdk/core/test/security/Cp4dServiceInstanceAuthenticatorTest.java
Show resolved
Hide resolved
src/test/java/com/ibm/cloud/sdk/core/test/security/Cp4dServiceInstanceAuthenticatorTest.java
Show resolved
Hide resolved
src/test/java/com/ibm/cloud/sdk/core/test/security/Cp4dServiceInstanceAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
padamstx
changed the title
padamstx
approved these changes
Nov 17, 2021
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 17, 2021
# [9.15.0](9.14.1...9.15.0) (2021-11-17) ### Features * **CloudPakForDataServiceInstanceAuthenticator:** add new cp4d service instance authenticator ([#156](#156)) ([9913071](9913071))
|
🎉 This PR is included in version 9.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new authenticator implementation that supports the "GET /v3/service_instances/serviceInstanceId/token"
operation which is part of the Cloud Pak For Data authentication service. This allows users to obtain
access tokens for service instances using the username, apikey, and service instance id in CP4D.