fix(plugins/plugin-kubectl): kubectl direct get may pass through kubeproxy 404s to user

This PR improves the error handling paths, to ensure that 1) http status codes are correctly passed through (there were some gaps); and 2) as an extra level of caution, we check for the specific kubeproxy 404 message

part of #7731

Author: starpit

plugins/plugin-kubectl/src/controller/client/direct/errors.ts

@@ -19,7 +19,7 @@ import { CodedError, isCodedError, REPL } from '@kui-shell/core'
 import URLFormatter from './url'
 import { headersForPlainRequest } from './headers'
 import { Status, isStatus } from '../../../lib/model/resource'
-import { fetchFile, FetchedFile, isReturnedError } from '../../../lib/util/fetch-file'
+import { fetchFile, FetchedFile, isReturnedError, ReturnedError } from '../../../lib/util/fetch-file'
 
 type WithErrors = {
   errors: CodedError[]
@@ -29,16 +29,16 @@ type WithErrors = {
 }
 
 /** See if the given error message is a Kubernetes Status object */
-export function tryParseAsStatus(message: string): string | Status {
+export function tryParseAsStatus(code: number | string, error: string): ReturnedError | Status {
   try {
-    const obj = JSON.parse(message)
+    const obj = JSON.parse(error)
     if (isStatus(obj)) {
       return obj
     } else {
-      return message
+      return { code, error }
     }
   } catch (err) {
-    return message
+    return { code, error }
   }
 }
 
@@ -51,7 +51,11 @@ export default async function handleErrors(
 ): Promise<WithErrors> {
   const withErrors: (string | Buffer | object | CodedError)[] = await Promise.all(
     responses.map(async data => {
-      let errorData = isReturnedError(data) ? tryParseAsStatus(data.error) : isStatus(data) ? data : undefined
+      let errorData = isReturnedError(data)
+        ? tryParseAsStatus(data.code, data.error)
+        : isStatus(data)
+        ? data
+        : undefined
       if (errorData) {
         if (isStatus(errorData)) {
           // if we could not find the requested resource, do some
@@ -89,8 +93,8 @@ export default async function handleErrors(
           return error
         } else {
           // some other random error, i.e. not a Kubernetes Status error
-          const error: CodedError = new Error(errorData)
-          error.code = 500
+          const error: CodedError<number | string> = new Error(errorData.error)
+          error.code = errorData.code || 500
           return error
         }
       }

plugins/plugin-kubectl/src/controller/client/direct/get.ts

@@ -196,7 +196,7 @@ export async function get(
     try {
       response = (await fetchFile(args.REPL, urls, { headers: { accept: 'application/json' } }))[0]
     } catch (err) {
-      response = tryParseAsStatus(err.message)
+      response = tryParseAsStatus(err.code, err.message)
       if (!isStatus(response)) {
         throw err
       }

plugins/plugin-kubectl/src/controller/kubectl/get.ts

@@ -283,7 +283,7 @@ async function rawGet(
         return response
       }
     } catch (err) {
-      if (err.code !== 500 && err.code !== undefined) {
+      if (err.code !== 500 && err.code !== undefined && !/page not found/.test(err.message)) {
         // expected apiServer error, i.e. Kubernetes Status errors
         throw err
       } else {

plugins/plugin-kubectl/src/lib/util/fetch-file.ts

@@ -150,7 +150,11 @@ export async function _needle(
 
     // internal usage: test kui's error handling of apiServer
     if (process.env.TRAVIS_CHAOS_TESTING) {
-      throw new Error('nope')
+      // simulate a condition where kuiproxy is not installed on the apiserver
+      const error: CodedError = new Error('404 page not found')
+      error.code = 404
+      error.statusCode = 404
+      throw error
     }
 
     try {
@@ -231,6 +235,7 @@ async function fetchRemote(repl: REPL, url: string, opts?: FetchOptions<BodyData
 }
 
 export type ReturnedError = {
+  code: number | string
   error: string
 }
 
@@ -264,7 +269,10 @@ export async function fetchFile(
           Object.assign({}, opts, { data: Array.isArray(opts.data) ? opts.data[idx] : opts.data })
         ).catch(err => {
           if (opts && opts.returnErrors) {
-            return { error: err.message || JSON.stringify(err) }
+            return {
+              code: err.code,
+              error: err.message || JSON.stringify(err)
+            }
           } else throw err
         })
       } else {