fix(packages/webpack): improve webpack watching scripts for dockerized runs

A few minor tweaks are needed to support running the watcher in a docker container

Author: starpit

packages/webpack/bin/watch.sh

@@ -22,6 +22,8 @@ set -o pipefail
 SCRIPTDIR=$(cd $(dirname "$0") && pwd)
 export CLIENT_HOME=$(cd "$SCRIPTDIR"/../../ && pwd)
 
+export KUI_BUILDDIR=${BUILDDIR-"$CLIENT_HOME"/dist/webpack}
+
 if [ -d "$SCRIPTDIR"/../@kui-shell ]; then
     # normally, this is in node_modules/.bin
     MODULE_HOME=$(cd "$SCRIPTDIR"/../@kui-shell && pwd)
@@ -37,9 +39,7 @@ HEADLESS_CONFIG="$MODULE_HOME"/webpack/headless-webpack.config.js
 
 THEME="${MODULE_HOME}"/client
 
-pushd "$CLIENT_HOME"
-  rm -rf dist/webpack
-popd
+rm -rf "$KUI_BUILDDIR"/dist/webpack/*
 
 if [ -n "$OPEN" ]; then
     OPEN="--open"
@@ -73,4 +73,6 @@ fi
 
 if [ "$WATCH_ARGS" = "open" ]; then
     npm run open
+elif [ "$WATCH_ARGS" = "wait" ]; then
+    wait
 fi

packages/webpack/webpack.config.js

@@ -416,6 +416,7 @@ module.exports = {
     devMiddleware: {
       writeToDisk: !inBrowser
     },
+    host: '0.0.0.0',
     allowedHosts:
       'all' /* webpack 4.43 -> 4.44 seemed to require this, otherwise console errors WDS Disconnected, and no auto-reload on save+recompile */,
     port
@@ -513,7 +514,11 @@ module.exports = {
   output: {
     globalObject: 'self', // for monaco
     filename: mode === 'production' ? '[name].[contenthash].bundle.js' : '[name].bundle.js',
-    publicPath: contextRoot || (inBrowser ? '/' : mode === 'production' ? '' : `${buildDir}/`),
+
+    // live watching should never use a contextRoot, otherwise you
+    // will get "Cannot GET /" errors
+    publicPath:
+      (process.env.WATCH !== 'true' && contextRoot) || (inBrowser ? '/' : mode === 'production' ? '' : `${buildDir}/`),
     path: outputPath
   }
 }