fix(plugins/plugin-kubectl): make sure to send helm to pty when needed

Author: starpit

plugins/plugin-kubectl/helm/src/controller/helm/catchall.ts

@@ -20,7 +20,9 @@ import { isUsage, doHelp, KubeOptions } from '@kui-shell/plugin-kubectl'
 import doExecWithPty from './exec'
 
 /** is the given string `str` the `helm` command? */
-const isHelm = (str: string) => /^helm$/.test(str)
+const isHelm = (argv: string[]) => {
+  return /^helm$/.test(argv[0]) && argv.every(arg => !/(\\|\n|;|&)/.test(arg)) // <-- no newlines or semicolons or && or &; just send those to the base catchall handler
+}
 
 export default (registrar: Registrar) => {
   if (Capabilities.inBrowser() && !Capabilities.hasProxy()) {
@@ -33,7 +35,7 @@ export default (registrar: Registrar) => {
   // found exceptions to the outer shell
   //
   registrar.catchall(
-    (argv: string[]) => isHelm(argv[0]),
+    (argv: string[]) => isHelm(argv),
     (args: Arguments<KubeOptions>) =>
       isUsage(args) || (args.argv.length === 1 && args.argv[0] === 'helm') ? doHelp('helm', args) : doExecWithPty(args),
     1 // priority

plugins/plugin-kubectl/helm/src/controller/helm/install.ts

@@ -15,7 +15,7 @@
  */
 
 import { Arguments, Registrar } from '@kui-shell/core'
-import { doHelp, getNamespaceForArgv, KubeOptions } from '@kui-shell/plugin-kubectl'
+import { doHelp, doExecWithPty, getNamespaceForArgv, KubeOptions } from '@kui-shell/plugin-kubectl'
 
 import isUsage from './usage'
 import doExecWithStdout from './exec'
@@ -25,6 +25,8 @@ const name = /^NAME:\s+([\w-]+)/
 async function doInstall(args: Arguments<KubeOptions>) {
   if (isUsage(args, 'install')) {
     return doHelp('helm', args)
+  } else if (/[\n;&]/.test(args.command)) {
+    return doExecWithPty(args, undefined, 'helm')
   }
 
   const response = await doExecWithStdout(args)