Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 1e74b8f

Browse files
starpitk8s-ci-robot
authored andcommitted
fix(plugins/plugin-client-common): Change block rerun action button from Retry icon to Play icon
part of #7696
1 parent 7508548 commit 1e74b8f

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

packages/test/src/api/selectors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export const BLOCK_DOWN_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--bloc
194194
export const BLOCK_SECTION_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--block-action [icon="Section"]`
195195
export const COMMAND_COPY_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--block-action [icon="Copy"]`
196196
export const COMMAND_COPY_DONE_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--block-action [icon="Checkmark"]`
197-
export const COMMAND_RERUN_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--block-action [icon="Retry"]`
197+
export const COMMAND_RERUN_BUTTON = (N: number) => `${PROMPT_BLOCK_N(N)} .kui--block-action [icon="Play"]`
198198
export const PROMPT_LAST = `${PROMPT_BLOCK_LAST} .repl-input-element`
199199
export const PROMPT_FINAL = `${PROMPT_BLOCK_FINAL} .repl-input-element`
200200
export const OUTPUT_LAST = `${PROMPT_BLOCK_LAST} .repl-result`

plugins/plugin-client-common/src/components/Views/Terminal/Block/Actions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export default class Actions extends React.PureComponent<Props> {
6464
}
6565
}
6666

67-
return <Action icon="Retry" onClick={handler} title={strings('Re-execute this command')} />
67+
return <Action icon="Play" onClick={handler} title={strings('Re-execute this command')} />
6868
}
6969
}
7070

plugins/plugin-client-common/web/scss/components/Terminal/Block.scss

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -196,28 +196,27 @@
196196
}
197197
}
198198
@include BlockActions {
199-
align-items: center;
200199
display: flex;
201200
opacity: 0;
202201
border-radius: 1px;
203202
background-color: var(--color-base03);
204203

204+
transition-property: opacity;
205+
transition-delay: $action-hover-delay;
206+
transition-duration: 140ms;
207+
205208
position: absolute;
206209
top: 0; /* this with bottom:0 gives 1) vertical center; 2) occluding of repl-input-element content */
207210
bottom: 0;
208211
right: 0;
209-
210-
padding-left: 0.5em;
211-
transition-property: opacity;
212-
transition-delay: $action-hover-delay;
213-
transition-duration: 140ms;
214212
}
215213

216214
.kui--block-action {
217215
align-items: center;
216+
justify-content: center;
218217
display: flex;
219-
margin-right: $action-padding;
220218
padding: $action-padding;
219+
width: $action-width;
221220
color: var(--color-text-01);
222221

223222
/* This is a bit of a hack for TwoFaceIcon, to work around the Checkmark being narrower than other icons in Carbon */
@@ -238,8 +237,6 @@
238237
}
239238

240239
.kui-block-actions-others:not(:empty) {
241-
padding-right: $action-padding;
242-
margin-right: $action-padding;
243240
display: flex;
244241
border-right: 1px solid var(--color-table-border1);
245242
}

plugins/plugin-client-common/web/scss/components/Terminal/_mixins.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ $inset: 0.375em;
2121
$right-element-font-size-factor: 0.75;
2222
$right-element-font-size: $right-element-font-size-factor + rem;
2323

24-
/** Padding for action buttons */
24+
/** Sizing for Block action buttons */
2525
$action-padding: 3px;
26+
$action-width: 2em;
2627

2728
/** Color to indicate focused block */
2829
$focus-color: var(--color-brand-01);

0 commit comments

Comments
 (0)