feat(packages/core): restore support for opening a popup window from headless mode

Author: starpit

packages/core/src/main/headless-pretty-print.ts

@@ -67,8 +67,14 @@ const colorMap: Record<string, ColorFunction> = {
 }
 
 let graphicalShellIsOpen = false
+/** @return whether the state has changed as a result of this call */
 export const setGraphicalShellIsOpen = () => {
-  graphicalShellIsOpen = true
+  if (!graphicalShellIsOpen) {
+    graphicalShellIsOpen = true
+    return true
+  } else {
+    return false
+  }
 }
 
 /**

packages/core/src/main/headless.ts

@@ -177,7 +177,10 @@ export const createWindow = async (argv: string[], subwindowPlease: boolean, sub
   try {
     graphicalShellIsOpen = true
     const { setGraphicalShellIsOpen } = await import('./headless-pretty-print')
-    setGraphicalShellIsOpen()
+    if (!setGraphicalShellIsOpen()) {
+      debug('probably a bug somewhere; detected loop in opening window from headless mode')
+      return
+    }
 
     const commandLine = argv
     if (commandContext) {

packages/core/src/main/spawn-electron.ts

@@ -559,6 +559,8 @@ export async function initElectron(
       // DEBUG=* or DEBUG=main
       const env = Object.assign({}, process.env, windowOptions)
       delete env.KUI_HEADLESS
+      delete env.ELECTRON_RUN_AS_NODE
+
       const child = spawn(Electron.toString(), args, {
         stdio: debug.enabled ? 'inherit' : 'ignore',
         env,

packages/core/src/repl/exec.ts

@@ -352,6 +352,21 @@ class InProcessExecutor implements Executor {
         return err
       }
 
+      // if we don't have a head (yet), but this command requires one,
+      // then ask for a head and try again. note that we ignore this
+      // needsUI constraint if the user is asking for help
+      if (
+        isHeadless() &&
+        !parsedOptions.cli &&
+        ((process.env.DEFAULT_TO_UI && !parsedOptions.cli) || (evaluator.options && evaluator.options.needsUI))
+      ) {
+        import('../main/headless').then(({ createWindow }) =>
+          createWindow(argv, evaluator.options.fullscreen, evaluator.options)
+        )
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        return (true as any) as T
+      }
+
       const execUUID = execOptions.execUUID || uuid()
       execOptions.execUUID = execUUID
       const evaluatorOptions = evaluator.options