fix: AskingTerminal can drop chunks coming from madwizard over raw stdout

re: the ||'' in Ask.tsx, this is just being extra cautious

Author: starpit

plugins/plugin-madwizard/components/src/Ask.tsx

@@ -215,7 +215,7 @@ export default class AskUI extends React.PureComponent<Props, State> {
   }
 
   private justTheMessage(choice: Ask['prompt']['choices'][number]) {
-    return stripAnsi(choice.message).replace('  ◄ prior choice', '')
+    return stripAnsi(choice.message || '').replace('  ◄ prior choice', '')
   }
 
   /** User has clicked on a simple list item */
@@ -291,7 +291,7 @@ export default class AskUI extends React.PureComponent<Props, State> {
         {message !== _.name && (
           <div>
             <Ansi noWrap="normal" className="sans-serif">
-              {_.message.split(/\n/).slice(-2)[0]}
+              {(_.message || '').split(/\n/).slice(-2)[0]}
             </Ansi>
           </div>
         )}
@@ -351,7 +351,7 @@ export default class AskUI extends React.PureComponent<Props, State> {
 
       // options other than the "suggested" (i.e. prior choice)
       const others = ask.prompt.choices
-        .filter(_ => _.name !== this.state?.userSelection && (!filter || pattern.test(_.message)))
+        .filter(_ => _.name !== this.state?.userSelection && (!filter || pattern.test(_.message || '')))
         .map(_ => this._selectOptionForChoice(_))
 
       // ugh, a bit of syntactic garbage here to make typescript
@@ -406,7 +406,7 @@ export default class AskUI extends React.PureComponent<Props, State> {
 
     // is every message the same as the title?
     const isSimplistic = ask.prompt.choices.every(
-      _ => _.name === stripAnsi(_.message).replace('  ◄ you selected this last time', '')
+      _ => _.name === stripAnsi(_.message || '').replace('  ◄ prior choice', '')
     )
 
     return (

plugins/plugin-madwizard/components/src/AskingTerminal.tsx

@@ -29,6 +29,16 @@ import SelectedProfileTerminal from './SelectedProfileTerminal'
 
 import '../../web/scss/components/Allotment/_index.scss'
 
+/** Be extra cautious parsing raw messages from madwizard */
+function tryToParseJson(str: string) {
+  try {
+    return JSON.parse(str)
+  } catch (err) {
+    console.error('Suspicious raw message from madwizard', str)
+    return JSON.parse(stripAnsi(str))
+  }
+}
+
 export type AskingProps = {
   terminalProps: Pick<RestartableProps, 'tab' | 'REPL' | 'onExit' | 'searchable' | 'fontSizeAdjust'>
 
@@ -132,7 +142,7 @@ export default class AskingTerminal extends React.PureComponent<Props, State> {
         const str = (this.leftover + line.slice(idx1 < 0 ? 0 : idx1, idx2)).slice(this.rawPrefix.length + 1)
         this.leftover = ''
         try {
-          const msg = JSON.parse(stripAnsi(str)) as
+          const msg = tryToParseJson(str) as
             | { type: 'qa-done' }
             | { type: 'all-done'; success: boolean }
             | { type: 'ask'; ask: Prompts.Prompt }
@@ -155,7 +165,9 @@ export default class AskingTerminal extends React.PureComponent<Props, State> {
           console.error('Error parsing line', idx1, idx2, line, '|||', str, err)
         }
       } else {
-        this.leftover += idx1 === 0 ? line : line.slice(idx1)
+        // we haven't reached the end of line, so stash what we have
+        // so far in this.leftover
+        this.leftover += idx1 <= 0 ? line : line.slice(idx1)
       }
       return null
     } else {