fix(plugins/plugin-bash-like): bash-like headless use of spawn unnecessarily sets the shell option

starpit · k8s-ci-robot · commit 3271a764c6e4 · 2021-04-26T10:59:16.000-07:00
part of #7338
diff --git a/plugins/plugin-bash-like/src/lib/cmds/bash-like.ts b/plugins/plugin-bash-like/src/lib/cmds/bash-like.ts
@@ -42,9 +42,6 @@ function doSpawn(
       const options: SpawnOptions = {
         env: Object.assign({}, process.env, execOptions['env'] || {})
       }
-      if (process.env.SHELL) {
-        options.shell = process.env.SHELL
-      }
 
       if (!execOptions.onInit && !execOptions.onExit && isHeadless() && !inProxy()) {
         options.stdio = 'inherit'

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,6 @@ function doSpawn(`
`42`	`42`	`const options: SpawnOptions = {`
`43`	`43`	`env: Object.assign({}, process.env, execOptions['env'] \|\| {})`
`44`	`44`	`}`
`45`		`- if (process.env.SHELL) {`
`46`		`- options.shell = process.env.SHELL`
`47`		`- }`
`48`	`45`
`49`	`46`	`if (!execOptions.onInit && !execOptions.onExit && isHeadless() && !inProxy()) {`
`50`	`47`	`options.stdio = 'inherit'`