fix: improved error handling for MixedResponse

1. in the core, we were transmitting on the error message for error parts of a multi-part response
2. incorrect serialization of code blocks with a part error
3. in code block rendering, no recognition of error parts

Author: starpit

packages/core/src/repl/exec.ts

@@ -735,7 +735,7 @@ async function semicolonInvoke(commands: string[], execOptions: ExecOptions): Pr
         return entity
       }
     } catch (err) {
-      return err.message
+      return err
     }
   })
 

plugins/plugin-client-common/src/components/Content/Markdown/frontmatter.tsx

@@ -32,12 +32,18 @@ export function tryFrontmatter(
   }
 }
 
+function stringifyError(response: Error) {
+  return { code: isCodedError(response) ? response.code : 1, message: response.message }
+}
+
 /** Blunt attempt to avoid serializing React bits */
 function reactRedactor(key: string, value: any) {
   if (key === 'tab') {
     return undefined
   } else if (key === 'block') {
     return undefined
+  } else if (typeof value === 'object' && value.constructor === Error) {
+    return stringifyError(value)
   } else {
     return value
   }
@@ -47,12 +53,7 @@ function encodePriorResponse(response: KResponse): { encoding: string; encodedRe
   return {
     encoding: 'base64+gzip',
     encodedResponse: Util.base64PlusGzip(
-      JSON.stringify(
-        response.constructor === Error
-          ? { code: isCodedError(response) ? response.code : 1, message: response.message }
-          : response,
-        reactRedactor
-      )
+      JSON.stringify(response.constructor === Error ? stringifyError(response) : response, reactRedactor)
     )
   }
 }

plugins/plugin-client-common/src/components/Views/Terminal/Block/Inputv2.tsx

@@ -307,7 +307,7 @@ export default class Input<T1, T2, T3> extends StreamingConsumer<Props<T1, T2, T
         : isError(response)
         ? 'error'
         : isMixedResponse(response)
-        ? response.find(_ => isXtermResponse(_) && _.code !== 0)
+        ? response.find(_ => (isXtermResponse(_) && _.code !== 0) || isError(_))
           ? 'error'
           : 'done'
         : 'done'