fix(plugins/plugin-kubectl): for now, send kubectl ... $(...) command lines to pty

At some point, we could get more sophisticated, and expand the $(...) subprocess executions, and still handle the rest in kui.

Author: starpit

plugins/plugin-kubectl/src/controller/kubectl/exec.ts

@@ -95,8 +95,10 @@ export function doExecWithStdout<O extends KubeOptions>(
  * required? That is, versus a plain nodejs spawn/exec.
  *
  */
-export function reallyNeedsPty({ argvNoOptions }: Pick<Arguments, 'argvNoOptions'>) {
-  return argvNoOptions.includes('|') || argvNoOptions.includes('>') || argvNoOptions.includes('>>')
+export function reallyNeedsPty({ argvNoOptions, parsedOptions }: Pick<Arguments, 'argvNoOptions' | 'parsedOptions'>) {
+  const test1 = (_: string) => /(\$\(|`)/.test(_) // subprocess execution?
+  const test2 = (_: string) => /^\s*(\||>|>>)\s*$/.test(_) || test1(_)
+  return !!argvNoOptions.find(test2) || !!Object.values(parsedOptions).find(test1)
 }
 
 /**