Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 3d17850

Browse files
starpitk8s-ci-robot
authored andcommitted
fix(plugins/plugin-s3): S3Mounts widget has high overhead on startup
part of #7576
1 parent fa29a99 commit 3d17850

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

plugins/plugin-s3/components/src/S3Mounts.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ import React from 'react'
1818
import commonPathPrefix from 'common-path-prefix'
1919
import { TableComposable, Tbody, Tr, Td } from '@patternfly/react-table'
2020

21-
import { Ansi, Icons, ViewLevel, Markdown, TextWithIconWidget, Tooltip } from '@kui-shell/plugin-client-common'
22-
23-
import { wireToStandardEvents, unwireToStandardEvents, i18n, encodeComponent } from '@kui-shell/core'
24-
21+
import { i18n, encodeComponent } from '@kui-shell/core'
2522
import { eventBus, Mount, getCurrentMounts } from '@kui-shell/plugin-s3'
23+
import { Ansi, Icons, ViewLevel, Markdown, TextWithIconWidget, Tooltip } from '@kui-shell/plugin-client-common'
2624

2725
import '../web/scss/S3Mounts.scss'
2826

@@ -92,15 +90,14 @@ export default class S3Mounts extends React.PureComponent<Props, State> {
9290
*
9391
*/
9492
public componentDidMount() {
95-
this.handler()
9693
eventBus.on('/s3/configuration/update', this.handler)
97-
wireToStandardEvents(this.handler)
94+
// wireToStandardEvents(this.handler)
9895
}
9996

10097
/** Make sure to unsubscribe! */
10198
public componentWillUnmount() {
10299
eventBus.off('/s3/configuration/update', this.handler)
103-
unwireToStandardEvents(this.handler)
100+
// unwireToStandardEvents(this.handler)
104101
}
105102

106103
/** @return the header for the Popover component */

0 commit comments

Comments
 (0)