Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 45d2975

Browse files
committed
fix(packages/core): cell onclick should be on inner
Fixes #3518
1 parent a72a339 commit 45d2975

File tree

2 files changed

+3
-3
lines changed
  • packages/core/src/webapp/views
  • plugins/plugin-core-support/src/test/core-support

2 files changed

+3
-3
lines changed

packages/core/src/webapp/views/table.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,8 @@ export const formatOneRowResult = (tab: Tab, options: RowFormatOptions = {}) =>
411411
parent.appendChild(cell)
412412

413413
if (onclick) {
414-
cell.classList.add('clickable')
415-
cell.onclick = async (evt: MouseEvent) => {
414+
inner.classList.add('clickable')
415+
inner.onclick = async (evt: MouseEvent) => {
416416
evt.stopPropagation() // don't trickle up to the row click handler
417417
if (isPopup() || options.usePip) {
418418
const { drilldown } = await import('../picture-in-picture')

plugins/plugin-core-support/src/test/core-support/theme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ const clickOnThemeButtonThenClickOnTheme = (clickOn: Theme) => (ctx: Common.ISui
9696
await new Promise(resolve => setTimeout(resolve, 300))
9797

9898
const checkMarkCell = `${Selectors.SIDECAR} .entity.theme[data-name="${clickOn.name}"] .entity-name.clickable`
99-
const nameCell = `${Selectors.SIDECAR} .entity.theme[data-name="${clickOn.name}"] > tr > .clickable`
99+
const nameCell = `${Selectors.SIDECAR} .entity.theme[data-name="${clickOn.name}"] > tr > td:not(.not-a-name) > .clickable`
100100

101101
console.error('A', checkMarkCell)
102102
await ctx.app.client.waitForVisible(checkMarkCell)

0 commit comments

Comments
 (0)