fix(packages/core): remove leftover console.trace

also cleans up lint member accessiblity violations

Fixes #3003

Author: starpit

packages/core/src/core/repl.ts

@@ -19,9 +19,6 @@
  *
  */
 
-console.trace()
-/* eslint-disable @typescript-eslint/explicit-member-accessibility */
-
 import Debug from 'debug'
 const debug = Debug('core/repl')
 debug('loading')
@@ -90,9 +87,9 @@ export interface ReplEval {
  *
  */
 export class DirectReplEval implements ReplEval {
-  name = 'DirectReplEval'
+  public name = 'DirectReplEval'
 
-  apply(commandUntrimmed: string, execOptions: ExecOptions, evaluator: Evaluator, args: EvaluatorArgs) {
+  public apply(commandUntrimmed: string, execOptions: ExecOptions, evaluator: Evaluator, args: EvaluatorArgs) {
     return evaluator.eval(args)
   }
 }
@@ -278,9 +275,9 @@ const emptyExecOptions = (): ExecOptions => new DefaultExecOptions()
  *
  */
 class InProcessExecutor implements Executor {
-  name = 'InProcessExecutor'
+  public name = 'InProcessExecutor'
 
-  async exec(commandUntrimmed: string, execOptions = emptyExecOptions()) {
+  public async exec(commandUntrimmed: string, execOptions = emptyExecOptions()) {
     const tab = execOptions.tab || cli.getCurrentTab()
     const REPL = getImpl(tab) // eslint-disable-line @typescript-eslint/no-use-before-define
 

plugins/plugin-manager/src/test/manager/plugin.ts

@@ -31,7 +31,7 @@ Common.localDescribe('plugin manager', function(this: Common.ISuite) {
       .then(reload)
       .catch(Common.oops(this, true)))
 
-  it('should try "sample hi" and fail', () =>
+  it('should try "hi" and fail', () =>
     CLI.command('hi', this.app)
       .then(ReplExpect.error(404))
       .catch(Common.oops(this, true)))
@@ -61,7 +61,7 @@ Common.localDescribe('plugin manager', function(this: Common.ISuite) {
     CLI.command('plugin commands @kui-shell/plugin-sample', this.app)
       .then(ReplExpect.okWithCustom({ expect: 'hello', passthrough: true }))
       .then(async N => {
-        await this.app.client.click(`${Selectors.OUTPUT_N(N)} .entity[data-name="sample hello"] .clickable`)
+        await this.app.client.click(`${Selectors.OUTPUT_N(N)} .entity[data-name="hello"] .clickable`)
         await this.app.client.waitForExist(Selectors.OUTPUT_N(N + 1))
         await this.app.client.waitForText(Selectors.OUTPUT_N(N + 1))
         return this.app.client.getText(Selectors.OUTPUT_N(N + 1))