fix(plugins/plugin-client-common): ClipboardTransfer emits errors when pasting non-json text

starpit · starpit · commit 6ff85c4535aa · 2020-10-02T17:07:31.000-07:00
Fixes #5836
diff --git a/plugins/plugin-client-common/src/components/Views/Terminal/ClipboardTransfer.ts b/plugins/plugin-client-common/src/components/Views/Terminal/ClipboardTransfer.ts
@@ -110,7 +110,9 @@ export function onPaste(this: ScrollableTerminal, evt: ClipboardEvent) {
         this.onExecEnd(uuid, false, complete, target.insertionIdx)
       }
     } catch (err) {
-      console.error(err)
+      // console.error(err)
+      // ok! this just means the user pasted something that isn't JSON
+      // see https://github.com/IBM/kui/issues/5836
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,9 @@ export function onPaste(this: ScrollableTerminal, evt: ClipboardEvent) {`
`110`	`110`	`this.onExecEnd(uuid, false, complete, target.insertionIdx)`
`111`	`111`	`}`
`112`	`112`	`} catch (err) {`
`113`		`- console.error(err)`
	`113`	`+ // console.error(err)`
	`114`	`+ // ok! this just means the user pasted something that isn't JSON`
	`115`	`+ // see https://github.com/IBM/kui/issues/5836`
`114`	`116`	`}`
`115`	`117`	`}`
`116`	`118`	`}`