fix(plugins/plugin-client-common): Tab uses strings rather than numbers for Close16 dimensions

starpit · starpit · commit 786447c1a47c · 2020-03-01T22:30:57.000-05:00
Fixes #3771
diff --git a/plugins/plugin-client-common/src/components/TopTabStripe/Tab.tsx b/plugins/plugin-client-common/src/components/TopTabStripe/Tab.tsx
@@ -140,7 +140,7 @@ export default class Tab extends React.PureComponent<Props, State> {
               this.props.onCloseTab(this.props.idx)
             }}
           >
-            <Close16 focusable="false" width="12" height="16" preserveAspectRatio="xMidYMid meet" aria-hidden="true" />
+            <Close16 focusable="false" width={12} height={16} preserveAspectRatio="xMidYMid meet" aria-hidden="true" />
           </div>
         )}
       </a>

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ export default class Tab extends React.PureComponent<Props, State> {`
`140`	`140`	`this.props.onCloseTab(this.props.idx)`
`141`	`141`	`}}`
`142`	`142`	`>`
`143`		`- <Close16 focusable="false" width="12" height="16" preserveAspectRatio="xMidYMid meet" aria-hidden="true" />`
	`143`	`+ <Close16 focusable="false" width={12} height={16} preserveAspectRatio="xMidYMid meet" aria-hidden="true" />`
`144`	`144`	`</div>`
`145`	`145`	`)}`
`146`	`146`	`</a>`