Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 79e7df3

Browse files
myan9starpit
authored andcommitted
fix(plugins/plugin-client-common): Sidecar sticks to a short height when switching from Yaml -> Summary -> Yaml tab
Fixed by removing sizeToFit in Editor and setting monaco-editor min-height to 20rem Fixes #6913
1 parent 423d1a6 commit 79e7df3

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/test/src/api/util.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,10 +278,13 @@ export function uniqueFileForSnapshot() {
278278
/** Click the close button on a block, and expect it to be gone */
279279
export async function removeBlock(res: AppAndCount) {
280280
const N = res.count
281-
await res.app.client.$(Selectors.PROMPT_N(N)).then(_ => _.moveTo())
281+
const prompt = await res.app.client.$(Selectors.PROMPT_N(N))
282+
await prompt.scrollIntoView()
283+
await prompt.moveTo()
282284

283285
const removeButton = await res.app.client.$(Selectors.BLOCK_REMOVE_BUTTON(N))
284-
await removeButton.waitForDisplayed()
286+
await removeButton.scrollIntoView()
287+
await removeButton.waitForDisplayed({ timeout: CLI.waitTimeout })
285288
await removeButton.click()
286289
}
287290

plugins/plugin-client-common/src/components/Content/KuiContent.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ export default class KuiContent extends React.Component<KuiMMRProps, State> {
117117
<Editor
118118
content={mode}
119119
readOnly={false}
120-
sizeToFit
121120
willUpdateToolbar={willUpdateToolbar}
122121
response={response}
123122
repl={tab.REPL}
@@ -131,7 +130,6 @@ export default class KuiContent extends React.Component<KuiMMRProps, State> {
131130
contentType={mode.contentType}
132131
originalContent={mode.content.a}
133132
modifiedContent={mode.content.b}
134-
sizeToFit
135133
response={response}
136134
renderSideBySide
137135
tabUUID={tab.uuid}

plugins/plugin-client-common/web/scss/components/Editor/Editor.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
.monaco-editor {
3636
display: block;
37+
min-height: 23rem;
3738
}
3839
.monaco-editor {
3940
background: transparent;

0 commit comments

Comments
 (0)