Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 8477386

Browse files
committed
fix(plugins/plugin-client-common): onclick handlers for ls should respond only to clicking on text
Fixes #6567
1 parent 69d45a9 commit 8477386

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

plugins/plugin-client-common/src/components/Content/Table/Grid.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ export default class Grid<P extends Props> extends React.PureComponent<P, State>
9999
style={{ gridTemplateColumns: `repeat(auto-fill, minmax(calc(${ex}ex + ${em}em), auto))` }}
100100
>
101101
{this.props.response.body.map(_ => (
102-
<div
103-
key={_.name}
104-
data-name={_.name}
105-
className={(_.css || '') + (_.onclick ? ' clickable' : '')}
106-
onClick={onClickForCell(_, this.props.tab, this.props.repl, _.onclick)}
107-
>
108-
{_.name}
102+
<div key={_.name} data-name={_.name} className={_.css}>
103+
<span
104+
className={_.onclick && 'clickable'}
105+
onClick={onClickForCell(_, this.props.tab, this.props.repl, _.onclick)}
106+
>
107+
{_.name}
108+
</span>
109109
</div>
110110
))}
111111
</div>

plugins/plugin-kubectl/src/test/k8s1/get-dash-o-name.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe(`kubectl get dash o name ${process.env.MOCHA_RUN_TARGET || ''}`, functi
6161
res
6262
)
6363
// now click on the table row
64-
await Util.openSidecarByClick(this, `${selector}.clickable`, 'nginx', defaultModeForGet).then(
64+
await Util.openSidecarByClick(this, `${selector} .clickable`, 'nginx', defaultModeForGet).then(
6565
SidecarExpect.yaml({ Status: 'Running' })
6666
)
6767
} catch (err) {

0 commit comments

Comments
 (0)