fix(plugins/plugin-client-common): Terminal focus changes unexpectedly

works around bug in carbon-components-react's OverflowMenu

Fixes #5170

Author: starpit

plugins/plugin-client-common/src/components/spi/DropDown/impl/Carbon.tsx

@@ -23,18 +23,35 @@ import Icons from '../../Icons'
 import '../../../../../web/scss/components/DropDown/Carbon.scss'
 
 export default class CarbonDropDown extends React.PureComponent<Props> {
+  private isOpen = false
+
+  /** re: isOpen, see the comment for the onOpen() method */
   private onClose() {
-    if (this.props.onClose) {
-      this.props.onClose()
+    if (this.isOpen) {
+      if (this.props.onClose) {
+        this.props.onClose()
+      }
+      this.isOpen = false
     }
   }
 
+  /**
+   * This will no longer be needed once we update to
+   * carbon-components-react
+   * 10.16. https://github.com/carbon-design-system/carbon/pull/6083
+   *
+   */
+  private onOpen() {
+    this.isOpen = true
+  }
+
   public render() {
     return (
       <OverflowMenu
         flipped
         menuOptionsClass={this.props.className}
         className={this.props.className}
+        onOpen={this.onOpen.bind(this)}
         onClose={this.onClose.bind(this)}
       >
         {this.props.actions.map((_, idx) => {