fix: hitting escape on initial page load toggles open empty sidecar

Fixes #4487

Author: starpit

packages/test/src/api/selectors.ts

@@ -4,6 +4,7 @@ export const TAB_SELECTED_N = (N: number) => `${TAB_N(N)}.visible`
 
 export const SIDECAR_BASE = `${CURRENT_TAB} .kui--sidecar`
 export const SIDECAR_FULLSCREEN = `${CURRENT_TAB} .kui--sidecar.visible.maximized:not(.minimized)`
+export const TERMINAL_WITH_SIDECAR_VISIBLE = `${CURRENT_TAB} .repl.sidecar-visible`
 export const PROMPT_BLOCK = `${CURRENT_TAB} .repl .repl-block`
 export const BOTTOM_PROMPT_BLOCK = `${CURRENT_TAB} .kui--input-stripe .repl-block`
 export const BOTTOM_PROMPT = `${BOTTOM_PROMPT_BLOCK} input`

plugins/plugin-client-common/src/components/Views/Sidecar/BaseSidecar.tsx

@@ -178,7 +178,7 @@ export abstract class BaseSidecar<
 
   /** Escape key toggles sidecar visibility */
   private onEscape(evt: KeyboardEvent) {
-    if (evt.key === 'Escape' && !document.getElementById('confirm-dialog') && !isPopup()) {
+    if (evt.key === 'Escape' && !document.getElementById('confirm-dialog') && !isPopup() && this.current) {
       if (this.props.willChangeSize) {
         this.props.willChangeSize(this.props.width === Width.Closed ? this.defaultWidth() : Width.Closed)
       }

plugins/plugin-client-common/src/components/Views/Sidecar/TopNavSidecar.tsx

@@ -326,8 +326,9 @@ export default class TopNavSidecar extends BaseSidecar<MultiModalResponse, Histo
 
   public render() {
     if (!this.current || !this.current.response) {
-      return <div>hi</div>
+      return <div />
     }
+
     try {
       const breadcrumbs = [
         this.kindBreadcrumb(),

plugins/plugin-core-support/src/test/core/basic-functionality.ts

@@ -22,7 +22,7 @@
 import * as assert from 'assert'
 import { Application } from 'spectron'
 
-import { Common, CLI } from '@kui-shell/test'
+import { CLI, Common, Selectors, Keys } from '@kui-shell/test'
 
 const APP_TITLE = process.env.APP_TITLE || 'Kui'
 // const CLI_PLACEHOLDER = process.env.CLI_PLACEHOLDER || 'enter your command'
@@ -57,6 +57,11 @@ Common.localDescribe('Basic Functionality', function(this: Common.ISuite) {
 
   it('has an initial focus on the CLI prompt', () => assert.ok(this.app.client.hasFocus(selectors.PROMPT)))
 
+  it('should do nothing when hitting escape key', async () => {
+    await this.app.client.keys(Keys.ESCAPE)
+    await this.app.client.waitForExist(Selectors.TERMINAL_WITH_SIDECAR_VISIBLE, 2000, true)
+  })
+
   /* it('has the expected placeholder text in the CLI prompt', async () => {
     try {
       const attr = await this.app.client.getAttribute(selectors.PROMPT, 'placeholder')