fix(plugins/plugin-kubectl): kubectl delete ns m1 m2 m3 m4 results in a one-row table

Fixes #5694

Author: starpit

plugins/plugin-client-common/web/css/static/ui.css

@@ -805,7 +805,7 @@ $kui--page-content-paragraph-padding: 0.375rem;
 .page-content p {
   padding: $kui--page-content-paragraph-padding 0;
 }
-.repl-output .page-content p:first-child {
+.repl-output .page-content p:only-child {
   padding: 0;
 }
 .page-content h1 {

plugins/plugin-kubectl/src/controller/kubectl/status.ts

@@ -194,13 +194,28 @@ async function getResourcesReferencedByCommandLine(
 ): Promise<ResourceRef[]> {
   // Notes: kubectl create secret <generic> <name> <-- the name is in a different slot :(
   const [kind, nameGroupVersion, nameAlt] = argvRest
+  const namespace = await getNamespace(args)
 
   const isDelete = args.parsedOptions['final-state'] === FinalState.OfflineLike
+  if (isDelete) {
+    // kubectl delete (ns [m1 m2 m2 m3])
+    //                ^ argvRest       ^
+    //                    ^ slice(1)  ^
+    return argvRest
+      .slice(1)
+      .map(nameGroupVersion => nameGroupVersion.split(/\./))
+      .map(([name, group, version]) => ({
+        group,
+        version,
+        kind,
+        name,
+        namespace
+      }))
+  }
+
   const isCreateSecret = !isDelete && /secret(s)?/i.test(kind)
   const [name, group, version] = isCreateSecret ? [nameAlt] : nameGroupVersion.split(/\./)
 
-  const namespace = await getNamespace(args)
-
   return [{ group, version, kind, name, namespace }]
 }
 

plugins/plugin-kubectl/src/test/k8s3/namespace.ts

@@ -18,27 +18,35 @@ import { strictEqual } from 'assert'
 import { Common, CLI, ReplExpect, SidecarExpect, Selectors } from '@kui-shell/test'
 import { waitForGreen, waitForRed, createNS, waitTillNone } from '@kui-shell/plugin-kubectl/tests/lib/k8s/utils'
 
-const ns1: string = createNS()
-const ns2: string = createNS()
+const ns1 = createNS()
+const ns2 = createNS()
+const ns3 = createNS()
+const ns4 = createNS()
 const synonyms = ['kubectl']
 
-describe(`kubectl namespace ${process.env.MOCHA_RUN_TARGET || ''}`, function(this: Common.ISuite) {
+describe(`kubectl namespace CRUD ${process.env.MOCHA_RUN_TARGET || ''}`, function(this: Common.ISuite) {
   before(Common.before(this))
   after(Common.after(this))
 
   synonyms.forEach(kubectl => {
-    /** delete the given namespace */
-    const deleteIt = (name: string, errOk = false) => {
-      it(`should delete the namespace ${name} via ${kubectl}`, () => {
-        return CLI.command(`${kubectl} delete namespace ${name}`, this.app)
-          .then(ReplExpect.okWithCustom({ selector: Selectors.BY_NAME(name) }))
-          .then(selector => waitForRed(this.app, selector))
-          .then(() => waitTillNone('namespace', undefined, name))
-          .catch(err => {
-            if (!errOk) {
-              return Common.oops(this, true)(err)
-            }
-          })
+    /** delete the given namespaces */
+    const deleteIt = (names: string[], errOk = false) => {
+      it(`should delete the namespaces ${names} via ${kubectl}`, async () => {
+        try {
+          const res = await CLI.command(`${kubectl} delete namespace ${names.join(' ')}`, this.app)
+
+          await Promise.all(
+            names.map(name => {
+              return ReplExpect.okWithCustom({ selector: Selectors.BY_NAME(name) })(res)
+                .then(selector => waitForRed(this.app, selector))
+                .then(() => waitTillNone('namespace', undefined, name))
+            })
+          )
+        } catch (err) {
+          if (!errOk) {
+            return Common.oops(this, true)(err)
+          }
+        }
       })
     }
 
@@ -205,7 +213,9 @@ describe(`kubectl namespace ${process.env.MOCHA_RUN_TARGET || ''}`, function(thi
     describeIt(ns2)
     createPod(ns1)
     createPod(ns2)
-    deleteIt(ns1)
+    createIt(ns3)
+    createIt(ns4)
+    deleteIt([ns1, ns3, ns4])
     deleteViaButton(ns2)
   })
 })