Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 9be1ae5

Browse files
committed
fix: Tree view badges can have low contrast
Fixes #6245
1 parent 4e1fea6 commit 9be1ae5

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

packages/core/src/webapp/themes/persistence.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ export const switchTo = async (theme: string, saveNotNeeded = false): Promise<vo
130130
document.body.setAttribute('kui-theme-key', themeKey)
131131
document.body.setAttribute('kui-theme-style', themeModel.style) // dark versus light
132132

133+
document.body.classList.add(themeModel.style === 'dark' ? 'pf-t-dark' : 'pf-t-light')
134+
133135
if (themeModel.attrs) {
134136
themeModel.attrs.forEach(attr => document.body.classList.add(attr))
135137
}

plugins/plugin-client-common/web/scss/PatternFly/kui-alignment.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,11 @@
130130
--pf-global--FontWeight--bold: 600;
131131
--pf-global--FontWeight--redhatfont--bold: 700;
132132

133-
--pf-global--link--Color: #06c;
133+
--pf-global--link--Color: var(--color-brand-01);
134134
--pf-global--link--Color--hover: #004080;
135-
--pf-global--link--Color--light: #73bcf7;
135+
--pf-global--link--Color--light: var(--color-brand-01);
136136
--pf-global--link--Color--light--hover: #2b9af3;
137-
--pf-global--link--Color--dark: #06c;
137+
--pf-global--link--Color--dark: var(--color-brand-01);
138138
--pf-global--link--Color--dark--hover: #004080;
139139

140140
--pf-global--BorderColor--100: #d2d2d2;
@@ -203,4 +203,6 @@
203203
--pf-global--link--Color: var(--pf-global--link--Color--light);
204204
--pf-global--link--Color--hover: var(--pf-global--link--Color--light);
205205
--pf-global--BackgroundColor--100: var(--pf-global--BackgroundColor--dark-100);
206+
--pf-global--BackgroundColor--200: var(--pf-global--BackgroundColor--dark-200);
207+
--pf-global--BackgroundColor--300: var(--pf-global--BackgroundColor--dark-300);
206208
}

plugins/plugin-core-themes/web/scss/dark.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ body[kui-theme='Dark'] {
1212
--color-base01: #202529; /* Lighter Background (Used for status bars) */
1313
--color-base02: #272c30; /* Selection Background */
1414
--color-base03: #373d42;
15-
--color-base04: #565656; /* Dark Foreground (Used for status bars) */
15+
--color-base04: #8d8d8d; /* Dark Foreground (Used for status bars) */
1616
--color-base05: #9fa5ad; /* Default Foreground, Caret, Delimiters, Operators */
1717
--color-base06: #f2f4f8; /* Light Foreground (Not often used) */
1818
--color-base07: #ffffff; /* Light Background (Not often used) */

plugins/plugin-core-themes/web/scss/light.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ body[kui-theme='Light'] .kui--inverted-color-context {
99
--color-base01: #202529; /* Lighter Background (Used for status bars) */
1010
--color-base02: #272c30; /* Selection Background */
1111
--color-base03: #373d42;
12-
--color-base04: #565656; /* Dark Foreground (Used for status bars) */
12+
--color-base04: #8d8d8d; /* Dark Foreground (Used for status bars) */
1313
--color-base05: #9fa5ad; /* Default Foreground, Caret, Delimiters, Operators */
1414
--color-base06: #f2f4f8; /* Light Foreground (Not often used) */
1515
--color-base07: #ffffff; /* Light Background (Not often used) */

0 commit comments

Comments
 (0)