fix(plugins/plugin-client-common): fix for react errors in Markdown and StatusStripe

1. we were calling (transitively) a setState from a render()
2. missing key in StatusStripe

Author: starpit

plugins/plugin-client-common/src/components/Client/StatusStripe/index.tsx

@@ -94,7 +94,7 @@ export default class StatusStripe extends React.PureComponent<Props, State> {
     return msg.split(pat).reduce(
       (M, _) => {
         if (_ === '') {
-          M.A.push(<strong>{bolds[M.idx++].replace(/\*\*/g, '')}</strong>)
+          M.A.push(<strong key={M.A.length + 1}>{bolds[M.idx++].replace(/\*\*/g, '')}</strong>)
         } else {
           M.A.push(_)
         }

plugins/plugin-client-common/src/components/Content/Markdown/frontmatter.tsx

@@ -158,7 +158,10 @@ export function kuiFrontmatter(opts: { tab: Tab }) {
             }
 
             if (frontmatter.title && typeof frontmatter.title === 'string') {
-              opts.tab.setTitle(frontmatter.title)
+              // don't do this synchronously. react complains about
+              // any transitive calls to setState() called from a
+              // render() method
+              setTimeout(() => opts.tab.setTitle(frontmatter.title))
             }
           } catch (err) {
             console.error('Error parsing Markdown yaml frontmatter', err)