Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit aa833b1

Browse files
committed
fix(plugins/plugin-carbon-themes): optimize loading of plex fonts
we don't need to load every last plex font variant Fixes #3831
1 parent 14d8895 commit aa833b1

File tree

9 files changed

+245
-230
lines changed

9 files changed

+245
-230
lines changed

packages/core/src/webapp/themes/persistence.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,10 @@ export const getPersistedThemeChoice = (): Promise<string> => {
4949
const getCss = async (addon: string, addonKey: string, plugin: string) => {
5050
return {
5151
key: addonKey,
52-
css: (await import('@kui-shell/plugin-' + webpackPath(plugin) + '/web/css/' + addon.replace(/\.css$/, '') + '.css'))
53-
.default
52+
css: /.scss/.test(addon)
53+
? await import('@kui-shell/plugin-' + webpackPath(plugin) + '/web/scss/' + addon.replace(/\.scss$/, '') + '.scss')
54+
: (await import('@kui-shell/plugin-' + webpackPath(plugin) + '/web/css/' + addon.replace(/\.css$/, '') + '.css'))
55+
.default
5456
}
5557
}
5658

plugins/plugin-carbon-themes/theme.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
"themes": [
33
{
44
"name": "Carbon Gray10",
5-
"css": ["carbon-gray10.css"],
5+
"css": ["carbon-gray10.scss"],
66
"attrs": ["kui--alternate", "kui--sidecar-inverted"],
77
"style": "light",
88
"topTabNames": "fixed"
99
},
1010
{
1111
"name": "Carbon Gray90",
12-
"css": ["carbon-gray90.css"],
12+
"css": ["carbon-gray90.scss"],
1313
"attrs": ["kui--alternate"],
1414
"style": "dark",
1515
"topTabNames": "fixed"

plugins/plugin-carbon-themes/web/css/carbon-gray10.css

Lines changed: 0 additions & 171 deletions
This file was deleted.

plugins/plugin-carbon-themes/web/css/ibm-plex.css

Lines changed: 0 additions & 6 deletions
This file was deleted.

plugins/plugin-carbon-themes/web/css/kui--alternate.css

Lines changed: 0 additions & 14 deletions
This file was deleted.
Lines changed: 173 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
1+
@import 'ibm-plex.scss';
2+
@import 'kui--alternate.scss';
3+
4+
/* inverted sidecar */
5+
body[kui-theme='Carbon Gray10'] {
6+
.kui--inverted-color-context {
7+
--color-base00: #262626;
8+
--color-base01: #171717;
9+
--color-base02: #565656;
10+
--color-base03: #565656;
11+
--color-base04: #8c8c8c;
12+
--color-base05: #adadad;
13+
--color-base06: #f3f3f3;
14+
--color-base07: #fff;
15+
--color-base08: #fa4d56;
16+
--color-base09: #bf5b17;
17+
--color-base0A: #fdd13a;
18+
--color-base0B: #56d679;
19+
--color-base0C: #30b0ff;
20+
--color-base0D: #4589ff;
21+
--color-base0E: #fa75a6;
22+
--color-base0F: #bb8eff;
23+
24+
--color-black: var(--color-ui-01);
25+
--color-red: var(--color-base08);
26+
--color-green: var(--color-base0B);
27+
--color-yellow: var(--color-base0A);
28+
--color-cyan: var(--color-base0C);
29+
--color-blue: var(--color-base0D);
30+
--color-magenta: var(--color-base0E);
31+
--color-white: var(--color-base07);
32+
--color-light-gray: var(--color-base04);
33+
--color-dark-gray: var(--color-base03);
34+
--color-ui-01: var(--color-base00);
35+
--color-ui-02: var(--color-base01);
36+
--color-ui-03: var(--color-base03);
37+
--color-ui-04: var(--color-base02);
38+
--color-ui-05: var(--color-base04);
39+
--color-ui-06: var(--color-base02);
40+
41+
--color-ok: var(--color-green);
42+
--color-error: var(--color-red);
43+
--color-warning: var(--color-base09);
44+
45+
--color-text-01: var(--color-base06);
46+
--color-text-02: var(--color-base04);
47+
color: var(--color-text-01);
48+
49+
--color-map-value: var(--color-text-01);
50+
--color-map-key: var(--color-base0C);
51+
--color-name: #30b0ff;
52+
53+
--color-brand-01: #97c1ff;
54+
--color-brand-02: var(--color-base07);
55+
--color-brand-03: var(--color-base0C);
56+
57+
--color-stripe-01: var(--color-base02);
58+
--color-stripe-02: var(--color-sidecar-header);
59+
60+
--color-sidecar-background-01: #171717;
61+
--color-sidecar-background-02: var(--color-base03);
62+
--color-name-sidecar: var(--color-name);
63+
64+
--color-screenshot-background: #3d3d3d; /* $ui-01 */
65+
--color-screenshot-primary-button-background: #0062ff; /* $interactive-01 */
66+
--color-screenshot-secondary-button-background: #6f6f6f; /* $interactive-02 */
67+
68+
--color-table-border1: rgba(255, 255, 255, 0.35);
69+
--color-table-border2: rgba(255, 255, 255, 0.5);
70+
--color-table-border3: var(--color-ui-04);
71+
}
72+
73+
/* color variables */
74+
& {
75+
--color-base00: #ffffff;
76+
--color-base01: #f3f3f3;
77+
--color-base02: #8c8c8c;
78+
--color-base03: #dcdcdc;
79+
--color-base04: #f2f4f8;
80+
--color-base05: #50565b;
81+
--color-base06: #171717;
82+
--color-base07: #fff;
83+
--color-base08: #da1e28;
84+
--color-base09: #bf5b17;
85+
--color-base0A: #8e6926;
86+
--color-base0B: #198038;
87+
--color-base0C: #0072c3;
88+
--color-base0D: #054ada;
89+
--color-base0E: #d12765;
90+
--color-base0F: #8a3ffc;
91+
92+
--color-red-sidecar: #fb4b53;
93+
--color-yellow-sidecar: #fdd13a;
94+
--color-green-sidecar: #56d679;
95+
96+
--color-brand-01: #0062ff;
97+
--color-brand-02: #171717;
98+
--color-brand-03: #0062ff;
99+
100+
--color-ui-05: #171717;
101+
--color-ui-03: #e0e0e0;
102+
--color-text-02: #565656;
103+
104+
--color-map-key: #6ea6ff;
105+
--color-map-value: var(--color-text-inverted01);
106+
107+
--color-table-border1: #9e9fa1;
108+
--color-table-border2: #3d4144;
109+
--color-table-border3: #a5adb4;
110+
111+
--color-sidecar-toolbar-foreground: var(--color-text-01);
112+
113+
--color-sidecar-header: #282828;
114+
--color-sidecar-background-01: var(--color-base06);
115+
--color-sidecar-border: #e4e4e4;
116+
117+
--color-brand-03: #008fff;
118+
--color-content-divider: #bfc0c2;
119+
120+
--color-stripe-01: var(--color-base03);
121+
--color-stripe-02: #f5f7fa;
122+
--tab-gray-text-color: var(--color-text-01);
123+
--active-tab-color: #0f62fe;
124+
--color-repl-background: var(--color-base01);
125+
126+
--color-light-red: hsla(354, 81%, 51%, 50%);
127+
--color-light-green: hsla(143, 73%, 43%, 50%);
128+
--color-light-yellow: hsla(46, 99%, 59%, 50%);
129+
130+
--color-support-04: var(--color-base0C);
131+
132+
/* from https://www.carbondesignsystem.com/data-visualization/color-palettes */
133+
--color-latency-0: #d4bbff;
134+
--color-latency-1: #08bdba;
135+
--color-latency-2: #007d79;
136+
--color-latency-3: #ff7eb6;
137+
--color-latency-4: #fa4d56;
138+
--color-latency-5: #fff1f1;
139+
--color-latency-6: #6fdc8c;
140+
--color-latency-7: #458dff;
141+
--color-latency-8: #d12771;
142+
--color-latency-9: #d2a106;
143+
--color-latency-10: #08bdba;
144+
--color-latency-11: #bae6ff;
145+
--color-latency-12: #ba4e00;
146+
--color-latency-13: #d4bbff;
147+
}
148+
149+
.monaco-editor .margin-view-overlays .current-line-margin,
150+
.monaco-editor .view-overlays .current-line {
151+
border-color: #565656;
152+
}
153+
.kui--sidecar .monaco-editor .mtk7,
154+
.kui--sidecar .monaco-editor .line-numbers {
155+
color: var(--color-sidecar-toolbar-background);
156+
}
157+
.monaco-editor .current-line ~ .line-numbers {
158+
color: #fa75a6;
159+
}
160+
.kui--input-stripe .repl-input {
161+
background-color: var(--color-base04);
162+
}
163+
.kui--input-stripe {
164+
background-color: var(--color-base00);
165+
}
166+
.kui--input-stripe input {
167+
background-color: var(--color-base01);
168+
}
169+
170+
.bx--data-table {
171+
font-family: var(--font-sans-serif);
172+
}
173+
}

0 commit comments

Comments
 (0)