fix(plugins/plugin-sidecar): regressions about defaultMode and order

Fixes #3710
Fixes #3709

Author: myan9

clients/test/plugins/plugin-test/src/lib/modes.ts

@@ -82,6 +82,7 @@ export const mode5 = {
     label: 'mode5 label',
     content: () => ({
       contentFrom: 'test string',
+      order: 999,
       contentType: 'text/plain' as const
     })
   }

clients/test/plugins/plugin-test/src/preload.ts

@@ -20,7 +20,7 @@ import { mode1, mode2, mode3, button, mode5, badge1, badge2 } from './lib/modes'
 
 export default async (registrar: PreloadRegistrar) => {
   if (!isHeadless()) {
-    registrar.registerModes(mode1, mode2, mode3, button, mode5)
+    registrar.registerModes(button, mode1, mode2, mode5, mode3)
     registrar.registerBadges(badge1, badge2)
   }
 }

plugins/plugin-sidecar/src/view/components/TopNavSidecar.tsx

@@ -47,7 +47,7 @@ interface State extends BaseState {
 }
 
 export function getStateFromMMR(tab: KuiTab, response: MultiModalResponse): State {
-  const allModes = response.modes.slice(0)
+  let allModes = response.modes.slice(0)
 
   // consult the view registrar for registered view modes
   // relevant to this resource
@@ -58,16 +58,20 @@ export function getStateFromMMR(tab: KuiTab, response: MultiModalResponse): Stat
     addRelevantModes(tab, allModes, command, response)
   }
 
+  // obey the `order` constraints of the modes
+  allModes = allModes.sort((a, b) => {
+    return (a.order || 0) - (b.order || 0)
+  })
+
   // defaultMode: if the response specified one, then look for it;
   // otherwise, use the mode that considers itself default;
   // otherwise use the first
-  const defaultModeFromResponse = response.defaultMode ? allModes.findIndex(_ => _.mode === response.defaultMode) : -1
+  const tabs = allModes.filter(_ => !isButton(_))
+  const defaultModeFromResponse = response.defaultMode ? tabs.findIndex(_ => _.mode === response.defaultMode) : -1
   const defaultModeFromModel =
-    defaultModeFromResponse === -1 ? allModes.findIndex(_ => _.defaultMode) : defaultModeFromResponse
+    defaultModeFromResponse === -1 ? tabs.findIndex(_ => _.defaultMode) : defaultModeFromResponse
   const defaultMode = defaultModeFromModel === -1 ? 0 : defaultModeFromModel
 
-  const tabs = allModes.filter(_ => !isButton(_))
-
   // re: as any: yay tsc, there are several open issue for this;
   // it's related to isButton using generics
   const buttonsFromRegistrar: Button[] = (allModes.filter(isButton) as any) as Button[]