Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit b32a940

Browse files
myan9k8s-ci-robot
authored andcommitted
fix(plugins/plugin-client-common): disable minisplit
1 parent 24e43f6 commit b32a940

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

plugins/plugin-client-common/src/components/Views/Terminal/ScrollableTerminal.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,16 +1164,17 @@ export default class ScrollableTerminal extends React.PureComponent<Props, State
11641164
* which indicates whether the given scrollback index is a
11651165
* minisplit.
11661166
*
1167+
* NOTE: minsplits are disable for now; see: https://github.com/kubernetes-sigs/kui/issues/7307
11671168
*/
11681169
private readonly theseAreMiniSplits = {
11691170
1: [false], // 1 split, not-minisplit
11701171
2: [false, false], // 2 splits, both not-minisplit
1171-
3: [true, true, false], // etc.
1172-
4: [true, true, false, false],
1173-
5: [true, true, true, false, false],
1174-
6: [true, true, true, false, false, false],
1175-
7: [true, true, false, true, true, false, false],
1176-
8: [true, true, true, true, true, true, true, false]
1172+
3: [false, false, false], // etc.
1173+
4: [false, false, false, false],
1174+
5: [false, false, false, false, false],
1175+
6: [false, false, false, false, false, false],
1176+
7: [false, false, false, false, false, false, false],
1177+
8: [false, false, false, false, false, false, false, false]
11771178
}
11781179

11791180
/**

plugins/plugin-client-common/web/scss/components/Terminal/Layout.scss

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,31 +57,30 @@
5757
.kui--terminal-split-container {
5858
/* two terminals */
5959
&[data-split-count='2'] {
60-
@include Rows(2);
60+
@include Rows(1);
6161
@include Columns(2);
62-
grid-template-areas:
63-
'T1 T2'
64-
'T1 T2';
62+
grid-template-areas: 'T1 T2';
6563
}
6664

6765
/* three terminals */
6866
&[data-split-count='3'] {
69-
@include Rows(3);
67+
@include Rows(5);
7068
@include Columns(2);
7169
grid-template-areas:
70+
'T1 T2'
71+
'T1 T2'
7272
'T1 T2'
7373
'T3 T3'
7474
'T3 T3';
7575
}
7676

7777
/* four terminals */
7878
&[data-split-count='4'] {
79-
@include Rows(3);
80-
@include Columns(4);
79+
@include Rows(2);
80+
@include Columns(2);
8181
grid-template-areas:
82-
'T1 T1 T2 T2'
83-
'T3 T3 T4 T4'
84-
'T3 T3 T4 T4';
82+
'T1 T2'
83+
'T3 T4';
8584
}
8685

8786
/* five terminals */

0 commit comments

Comments
 (0)