fix(plugins/plugin-editor): Editor component should be readOnly for non-files

myan9 · starpit · commit b537d5c2a986 · 2020-02-18T18:39:35.000-05:00
Fixes #3641
diff --git a/plugins/plugin-editor/src/view/components/Editor.tsx b/plugins/plugin-editor/src/view/components/Editor.tsx
@@ -165,7 +165,7 @@ export default class Editor extends React.PureComponent<Props, State> {
       // here we instantiate an editor widget
       const providedOptions = {
         value: props.content.content,
-        readOnly: props.readOnly || false,
+        readOnly: props.readOnly || !isFile(props.response) || false,
         language: props.content.contentType ? language(props.content.contentType) : undefined
       }
       const options = Object.assign(defaultMonacoOptions(providedOptions), providedOptions)

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ export default class Editor extends React.PureComponent<Props, State> {`
`165`	`165`	`// here we instantiate an editor widget`
`166`	`166`	`const providedOptions = {`
`167`	`167`	`value: props.content.content,`
`168`		`- readOnly: props.readOnly \|\| false,`
	`168`	`+ readOnly: props.readOnly \|\| !isFile(props.response) \|\| false,`
`169`	`169`	`language: props.content.contentType ? language(props.content.contentType) : undefined`
`170`	`170`	`}`
`171`	`171`	`const options = Object.assign(defaultMonacoOptions(providedOptions), providedOptions)`