Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit cbceee3

Browse files
committed
fix(plugins/plugin-client-common): sidecar toolbar text is not always vertically centered
Fixes #6305
1 parent b09391e commit cbceee3

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

plugins/plugin-client-common/web/css/static/SidecarCommon.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
body {
1818
--color-sidecar-header: var(--color-base03);
19+
--color-sidecar-background: var(--color-base01);
1920
--color-sidecar-background-01: var(--color-base01);
2021
--color-sidecar-background-02: var(--color-base03);
2122
}

plugins/plugin-client-common/web/css/static/sidecar-main.css

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
@import "SidecarCommon.css";
1818

19+
$toolbar-height: 1.5rem;
20+
1921
.kui--sidecar {
2022
height: 100%;
2123
max-height: 100%;
@@ -94,17 +96,28 @@
9496
display: flex;
9597
overflow: visible; /* for tooltip visibility */
9698

97-
.sidecar-toolbar-text p {
98-
font-size: inherit;
99-
line-height: unset;
99+
.sidecar-toolbar-text {
100+
p {
101+
font-size: inherit;
102+
}
103+
em {
104+
padding: 0.125em 1em;
105+
margin: 0 1.25em;
106+
font-style: normal;
107+
display: inline-block;
108+
color: var(--color-sidecar-toolbar-background);
109+
background-color: var(--color-sidecar-toolbar-foreground);
110+
border-radius: 0.9375em;
111+
mix-blend-mode: difference;
112+
}
100113
}
101114

102115
.sidecar-toolbar-text,
103116
.sidecar-bottom-stripe-mode-bits {
104117
background-color: var(--color-sidecar-toolbar-background);
105118
color: var(--color-sidecar-toolbar-foreground);
106-
height: 1.5em;
107-
line-height: 1.5em;
119+
height: $toolbar-height;
120+
line-height: $toolbar-height;
108121
display: flex;
109122
align-items: center;
110123
flex: 1;
@@ -138,10 +151,6 @@
138151
+ .sidecar-bottom-stripe-mode-bits.sidecar-bottom-stripe-button-container:not(:empty) {
139152
flex: 1;
140153
}
141-
.sidecar-toolbar-text-icon,
142-
.sidecar-toolbar-text-content {
143-
opacity: 0.875;
144-
}
145154
.sidecar-toolbar-text-icon {
146155
margin-right: 0.375em;
147156
padding-left: 1em;
@@ -174,6 +183,7 @@
174183
color: inherit;
175184
background-color: transparent;
176185
border: none;
186+
font-size: inherit;
177187
&:hover {
178188
cursor: pointer;
179189
[role="tab"] {
@@ -190,7 +200,7 @@
190200
fill: var(--color-sidecar-toolbar-foreground);
191201
}
192202
.sidecar-bottom-stripe-mode-bits.sidecar-bottom-stripe-button-container {
193-
padding: 0 0.375em;
203+
padding: 0 0.375em 0 1em;
194204
display: flex;
195205
flex: initial;
196206
}

0 commit comments

Comments
 (0)