fix(plugins/plugin-client-common): sidecar does not resopnd to Escape reliably

1) escape does not close LeftNavSidecar reliably; this is due to an incorrect guard of isFixedWidth() around the onEscape registration
Fixes #4774

2) escape closes sidecars in all tabs; we need to pay attention to whether the sidecar is part of the active KuiTab
Fixes #4804

Author: starpit

plugins/plugin-client-common/src/components/Client/TabContent.tsx

@@ -341,6 +341,7 @@ export default class TabContent extends React.PureComponent<Props, State> {
       return React.cloneElement(node, {
         key,
         uuid: this.props.uuid,
+        active: this.props.active,
         width: this.state.sidecarWidth,
         willChangeSize: this.onWillChangeSize.bind(this),
         willLoseFocus: this.onWillLoseFocus.bind(this)

plugins/plugin-client-common/src/components/Views/Sidecar/BaseSidecar.tsx

@@ -52,6 +52,7 @@ export interface SidecarOptions {
 export type Props = SidecarOptions & {
   uuid?: string
   tab?: KuiTab
+  active?: boolean
 }
 
 export interface SidecarHistoryEntry extends BaseHistoryEntry {
@@ -88,13 +89,11 @@ export abstract class BaseSidecar<
     super(props)
 
     // Interpret Escape key as a toggle of the view's width
-    if (!this.isFixedWidth()) {
-      const onEscape = this.onEscape.bind(this)
-      document.addEventListener('keydown', onEscape)
-      this.cleaners.push(() => document.removeEventListener('keydown', onEscape))
-      // ^^^ Note! keydown versus keyup is important (for now at
-      // least; @starpit 20200408); see https://github.com/IBM/kui/issues/4215
-    }
+    const onEscape = this.onEscape.bind(this)
+    document.addEventListener('keydown', onEscape)
+    this.cleaners.push(() => document.removeEventListener('keydown', onEscape))
+    // ^^^ Note! keydown versus keyup is important (for now at
+    // least; @starpit 20200408); see https://github.com/IBM/kui/issues/4215
   }
 
   public componentDidCatch(error: Error, errorInfo: React.ErrorInfo) {
@@ -189,7 +188,13 @@ export abstract class BaseSidecar<
 
   /** Escape key toggles sidecar visibility */
   private onEscape(evt: KeyboardEvent) {
-    if (evt.key === 'Escape' && !document.getElementById('confirm-dialog') && !isPopup() && this.current) {
+    if (
+      evt.key === 'Escape' &&
+      this.props.active &&
+      !document.getElementById('confirm-dialog') &&
+      !isPopup() &&
+      this.current
+    ) {
       if (this.props.willChangeSize) {
         this.props.willChangeSize(this.props.width === Width.Closed ? this.defaultWidth() : Width.Closed)
       }