feat(packages/core): allow controller to opt in/out recording table row onclicks when snapshot

Fixes #5565

Author: myan9

packages/core/src/webapp/models/table.ts

@@ -69,7 +69,9 @@ export class Row {
 
   rowCSS?: string | string[]
 
-  onclickSilence?: boolean
+  onclickSilence?: boolean // opt in/out recording click events when snapshot
+
+  onclickIdempotent?: boolean
 
   onclickExec?: 'pexec' | 'qexec'
 

plugins/plugin-core-support/src/lib/cmds/replay.ts

@@ -163,7 +163,9 @@ class FlightRecorder {
           ? {
               completeEvent: _.completeEvent,
               onClicks: _.completeEvent.response.body
-                .map((_, rowIdx) => (typeof _.onclick === 'string' ? { rowIdx, onClick: _.onclick } : undefined))
+                .map((_, rowIdx) =>
+                  _.onclickIdempotent && typeof _.onclick === 'string' ? { rowIdx, onClick: _.onclick } : undefined
+                )
                 .filter(_ => _)
             }
           : undefined

plugins/plugin-kubectl/src/lib/view/formatTable.ts

@@ -318,6 +318,7 @@ export const formatTable = async <O extends KubeOptions>(
         rowKey,
         fontawesome: idx !== 0 && rows[0].key === 'CURRENT' && 'fas fa-check',
         onclick: nameColumnIdx === 0 && onclick, // if the first column isn't the NAME column, no onclick; see onclick below
+        onclickIdempotent: true,
         onclickSilence: true,
         css: firstColumnCSS + (rows[0].key === nameColumn ? ' kui--table-cell-is-name' : ''),
         rowCSS,