fix(plugins/plugin-client-common): TabContainer and TabContent double render on startup

part of #7929

Author: starpit

plugins/plugin-client-common/src/components/Client/TabContainer.tsx

@@ -43,20 +43,19 @@ interface State {
   /** list of current tabs; one TabContent for each */
   tabs: TabModel[]
 
-  /** Has the first tab activated itself? */
-  isFirstTabReady: boolean
-
   /** current active tab index */
   activeIdx: number
 }
 
 export default class TabContainer extends React.PureComponent<Props, State> {
+  /** Has the first tab activated itself? */
+  private isFirstTabReady = false
+
   public constructor(props: Props) {
     super(props)
 
     this.state = {
       tabs: [this.newTabModel()],
-      isFirstTabReady: false,
       activeIdx: 0
     }
 
@@ -221,11 +220,11 @@ export default class TabContainer extends React.PureComponent<Props, State> {
 
   private onTabReady(tab: Tab) {
     // "initial tab" handling
-    if (!this.state.isFirstTabReady) {
+    if (!this.isFirstTabReady) {
       if (this.props.onTabReady) {
         this.props.onTabReady(tab)
       }
-      this.setState({ isFirstTabReady: true })
+      this.isFirstTabReady = true
     }
 
     // then, for all tabs: we were asked to execute a command line in
@@ -283,7 +282,6 @@ export default class TabContainer extends React.PureComponent<Props, State> {
             key={_.uuid}
             uuid={_.uuid}
             active={idx === this.state.activeIdx}
-            willUpdateTopTabButtons={this.willUpdateTopTabButtons.bind(this, _.uuid)}
             onTabReady={this._onTabReady}
             state={_.state}
           >

plugins/plugin-client-common/src/components/Client/TabContent.tsx

@@ -18,7 +18,6 @@ import React from 'react'
 import { eventChannelUnsafe, eventBus, Tab as KuiTab, TabState, initializeSession } from '@kui-shell/core'
 
 import KuiContext from './context'
-import { TopTabButton } from './TabModel'
 const Confirm = React.lazy(() => import('../Views/Confirm'))
 
 import getSize from '../Views/Terminal/getSize'
@@ -48,7 +47,6 @@ type Props = TabContentOptions &
     state: TabState
     snapshot?: Buffer
     tabTitle?: string
-    willUpdateTopTabButtons?: (buttons: TopTabButton[]) => void
   }
 
 type SessionInitStatus = 'NotYet' | 'InProgress' | 'Reinit' | 'Done' | 'Error'