Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit d63a6f1

Browse files
committed
fix(plugins/plugin-client-common): improve spacing of Event footer content
also fixes a color contrast issue with color-base0F in carbon dark Fixes #5178
1 parent 5b54665 commit d63a6f1

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

plugins/plugin-carbon-themes/web/scss/colors.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
--color-base0C: #30b0ff;
3535
--color-base0D: #4589ff;
3636
--color-base0E: #fa75a6;
37-
--color-base0F: #bb8eff;
37+
--color-base0F: #d4bbff;
3838

3939
--color-confirm-background: var(--color-sidecar-header);
4040
--color-confirm-foreground: var(--color-base06);

plugins/plugin-client-common/web/scss/components/Table/Events.scss

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17+
$inter-message-spacing: 0.1875rem;
18+
1719
.kui--data-table-container {
1820
.kui--data-table-footer-message {
1921
/* this tells the browser to line wrap according to the width dictated by the rest of the table */
@@ -40,7 +42,7 @@
4042
/* applies only to tables */
4143
.kui--data-table-container {
4244
.kui--data-table-footer-messages {
43-
height: 1.5rem;
45+
height: auto;
4446
}
4547
}
4648

@@ -60,6 +62,7 @@
6062
}
6163

6264
a {
65+
line-height: initial;
6366
color: var(--color-base0F);
6467
font-weight: normal;
6568
font-size: 0.75rem;
@@ -68,20 +71,23 @@
6871
}
6972

7073
tr:not(.kui--data-table-footer-messages) + .kui--data-table-footer-messages,
71-
.kui--data-table-toolbar-filler + .kui--data-table-footer-messages {
74+
.kui--data-table-toolbar-filler + .kui--data-table-footer-messages,
75+
.kui--data-table-footer-messages:first-child {
7276
.kui--data-table-footer-message {
73-
padding-top: 0.5rem;
77+
padding-top: calc(2 * #{$inter-message-spacing});
7478
}
7579
}
76-
.kui--data-table-footer-messages:last-child {
80+
81+
.kui--data-table-footer-messages {
7782
.kui--data-table-footer-message {
78-
padding-bottom: 0.5rem;
83+
padding-top: 0;
84+
padding-bottom: 0;
7985
}
8086
}
8187

82-
.kui--data-table-footer-messages:not(:last-child) {
88+
.kui--data-table-footer-messages:last-child {
8389
.kui--data-table-footer-message {
84-
padding-bottom: 0;
90+
padding-bottom: calc(2.5 * #{$inter-message-spacing});
8591
}
8692
}
8793
}

0 commit comments

Comments
 (0)