fix(plugins/plugin-client-common): improve platform compatibility of Home and End keys

This PR addresses both shift+Home/End behavior on macOS, and Home/End behavior on Linux/Windows. In both cases, Kui's behavior should now match that of the platform terminal.

Note: browsers on macOS seem to interpret shift+Home as meaning "select all to beginning of line", whereas macOS Terminal interprets shift+Home to mean "move caret to beginning of line". Thus, Kui still (for darwin only) needs to override the default behavior, though just for this one case.

Fixes #3267

Author: starpit

plugins/plugin-client-common/src/components/Views/Terminal/Block/OnKeyDown.ts

@@ -53,6 +53,7 @@ const setCaretPosition = (ctrl: HTMLInputElement, pos: number) => {
   }
 }
 
+const setCaretPositionToStart = (input: HTMLInputElement) => setCaretPosition(input, 0)
 const setCaretPositionToEnd = (input: HTMLInputElement) => setCaretPosition(input, input.value.length)
 
 /** Update the given input to reflect the given HistoryLine */
@@ -161,22 +162,12 @@ export default function onKeyDown(this: Input, event: KeyboardEvent) {
     // restore the prompt cursor position
     // debug('restoring cursor position', currentCursorPosition)
     // getCurrentPrompt().setSelectionRange(currentCursorPosition, currentCursorPosition)
-  } else if (char === KeyCodes.HOME) {
-    // go to first command in history
-    setTimeout(async () => {
-      const historyModel = await (await import('@kui-shell/core')).History(tab)
-      const entry = historyModel.first()
-      if (entry) {
-        updateInputAndMoveCaretToEOL(this, entry)
-      }
-    })
-  } else if (char === KeyCodes.END) {
-    // go to last command in history
-    setTimeout(async () => {
-      const historyModel = await (await import('@kui-shell/core')).History(tab)
-      const entry = historyModel.last()
-      updateInputAndMoveCaretToEOL(this, entry)
-    })
+  } else if (event.key === 'Home' && event.shiftKey && process.platform === 'darwin') {
+    // go to beginning of line
+    setCaretPositionToStart(prompt)
+  } else if (event.key === 'End' && event.shiftKey && process.platform === 'darwin') {
+    // go to end of line
+    setCaretPositionToEnd(prompt)
   } else if (char === KeyCodes.DOWN || (char === KeyCodes.N && event.ctrlKey)) {
     // going DOWN past the last history item will result in '', i.e. a blank line
     setTimeout(async () => {