fix(plugins/plugin-client-common): patternfly popover close button has odd spacing

Fixes #6345

Author: starpit

plugins/plugin-client-common/src/components/spi/Popover/impl/PatternFly.tsx

@@ -18,7 +18,7 @@ import React from 'react'
 import { Popover } from '@patternfly/react-core'
 
 import Props from '../model'
-import '../../../../../web/scss/components/Popover/common.scss'
+import '../../../../../web/scss/components/Popover/PatternFly.scss'
 
 export default function PatternFlyPopover(props: Props) {
   return (

plugins/plugin-client-common/web/scss/components/Popover/Carbon.scss

@@ -15,19 +15,22 @@
  */
 
 @import 'common';
+@import 'mixins';
 @import '~carbon-components/scss/components/tooltip/_tooltip.scss';
 
 .kui--status-stripe-element-wrapper.bx--tooltip__label {
   align-items: unset;
   color: var(--color-text-01);
 }
 
-.kui--popover.bx--tooltip {
-  max-width: 40rem; /* hmm, Carbon doesn't make this easy */
-  color: var(--color-text-01);
-  background: var(--color-base02);
+@include Popover {
+  &.bx--tooltip {
+    max-width: 40rem; /* hmm, Carbon doesn't make this easy */
+    color: var(--color-text-01);
+    background: var(--color-base02);
 
-  a {
-    color: var(--color-base0C);
+    a {
+      color: var(--color-base0C);
+    }
   }
 }

plugins/plugin-client-common/web/scss/components/Popover/PatternFly.scss

@@ -15,3 +15,10 @@
  */
 
 @import 'common';
+@import 'mixins';
+
+@include Popover {
+  .pf-c-button {
+    padding: 0;
+  }
+}

plugins/plugin-client-common/web/scss/components/Popover/_mixins.scss

@@ -0,0 +1,21 @@
+/*
+ * Copyright 2020 IBM Corporation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@mixin Popover {
+  .kui--popover {
+    @content;
+  }
+}

plugins/plugin-client-common/web/scss/components/Popover/common.scss

@@ -14,8 +14,12 @@
  * limitations under the License.
  */
 
-body[kui-theme-style] .kui--popover {
-  min-width: 5rem;
+@import 'mixins';
+
+body[kui-theme-style] {
+  @include Popover {
+    min-width: 5rem;
+  }
 }
 
 .kui--status-stripe-element-wrapper:hover,