fix(plugins/plugin-kubectl): kubectl logs -l with no matches yields internal error

Fixes #4811

Author: starpit

plugins/plugin-kubectl/i18n/logs_en_US.json

@@ -7,6 +7,7 @@
   "Message": "Message",
   "Details": "Details",
   "No log data": "No log data",
+  "No matching pods": "No matching pods",
   "Logs are live streaming. Showing all containers.": "Logs are live **streaming**. Showing **all containers**.",
   "Log streaming is paused. Showing all containers.": "Log streaming is **paused**. Showing **all containers**.",
   "Log streaming stopped. Showing all containers.": "Log streaming **stopped**. Showing **all containers**.",

plugins/plugin-kubectl/logs/src/controller/kubectl/logs.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { Arguments, CodedError, ExecType, MultiModalResponse, Registrar, flatten } from '@kui-shell/core'
+import { Arguments, CodedError, ExecType, MultiModalResponse, Registrar, flatten, i18n } from '@kui-shell/core'
 import {
   isUsage,
   doHelp,
@@ -28,6 +28,7 @@ import {
   getContainer,
   getNamespace,
   KubeItems,
+  isKubeItems,
   isKubeItemsOfKind,
   KubeResource,
   Pod,
@@ -36,6 +37,8 @@ import {
 
 import commandPrefix from '../command-prefix'
 
+const strings = i18n('plugin-kubectl', 'logs')
+
 interface LogOptions extends KubeOptions {
   f: string
   follow: string
@@ -142,6 +145,11 @@ function viewTransformer(defaultMode: string) {
   return async (args: Arguments<KubeOptions>, response: KubeResource | KubeItems<Pod>) => {
     if (isKubeItemsOfKind(response, isPod)) {
       return transformMulti(defaultMode, args, response)
+    } else if (isKubeItems(response)) {
+      // otherwise, we have an empty list of items
+      const error: CodedError = new Error(strings('No matching pods'))
+      error.code = 404
+      throw error
     }
 
     if (isPod(response)) {

plugins/plugin-kubectl/logs/src/test/logs/logs-via-label.ts

@@ -0,0 +1,34 @@
+/*
+ * Copyright 2020 IBM Corporation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Common, CLI, ReplExpect } from '@kui-shell/test'
+import { createNS, allocateNS, deleteNS } from '@kui-shell/plugin-kubectl/tests/lib/k8s/utils'
+
+describe(`kubectl logs via label ${process.env.MOCHA_RUN_TARGET || ''}`, function(this: Common.ISuite) {
+  before(Common.before(this))
+  after(Common.after(this))
+
+  const ns: string = createNS()
+
+  allocateNS(this, ns)
+
+  it('should fail with 404 when querying with bogus label', () =>
+    CLI.command(`kubectl logs -lxxxxxxxxx=yyyyyyyyyyy -n ${ns}`, this.app)
+      .then(ReplExpect.error(404))
+      .catch(Common.oops(this, true)))
+
+  deleteNS(this, ns)
+})