fix(packages/core): isHTML fails if input is null

starpit · starpit · commit eecdbac659b9 · 2019-10-16T19:57:52.000-04:00
Fixes #3019
diff --git a/packages/core/src/util/types.ts b/packages/core/src/util/types.ts
@@ -19,7 +19,7 @@ import { MessageWithUsageModel } from '../core/usage-error'
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function isHTML(message: Entity | MessageWithUsageModel | Node): message is HTMLElement {
-  return !!(message as HTMLElement).nodeName
+  return !!message && !!(message as HTMLElement).nodeName
 }
 
 export function isPromise<T, U>(content: U | Promise<T>): content is Promise<T> {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ import { MessageWithUsageModel } from '../core/usage-error'`
`19`	`19`
`20`	`20`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`21`	`21`	`export function isHTML(message: Entity \| MessageWithUsageModel \| Node): message is HTMLElement {`
`22`		`- return !!(message as HTMLElement).nodeName`
	`22`	`+ return !!message && !!(message as HTMLElement).nodeName`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`export function isPromise<T, U>(content: U \| Promise<T>): content is Promise<T> {`