Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit f1bc709

Browse files
committed
fix: xterm alt buffer mode behaves oddly for clients that do not enable splitTerminals
Fixes #5003
1 parent d96def0 commit f1bc709

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

plugins/plugin-bash-like/src/pty/client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const exitAltBufferPattern = /\x1b\[\??(47|1047|1049)l/
5353

5454
import copy from './copy'
5555

56-
import '../../web/css/static/xterm.css'
56+
import '../../web/scss/xterm.scss'
5757

5858
interface Size {
5959
resizeGeneration: number

plugins/plugin-bash-like/web/css/static/xterm.css renamed to plugins/plugin-bash-like/web/scss/xterm.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ disabled see https://github.com/IBM/kui/issues/3939
3939
height: auto !important;
4040
}
4141

42-
/* alt buffer mode */
43-
.xterm-alt-buffer-mode {
42+
/* alt buffer mode */
43+
&.xterm-alt-buffer-mode, .xterm-alt-buffer-mode { /* no-splitTerminal and splitTerminal variants */
4444
.xterm-container .xterm-rows.xterm-focus .xterm-cursor.xterm-cursor-block {
4545
background-color: var(--color-base08);
4646
color: var(--color-base00);

plugins/plugin-kubectl/web/scss/components/Terminal/Terminal.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
@import '~@kui-shell/plugin-bash-like/web/css/static/xterm.css';
17+
@import '~@kui-shell/plugin-bash-like/web/scss/xterm';
1818

1919
.kui--terminal[data-needs-hysteresis='true'][data-got-some-data='false'] .xterm {
2020
opacity: 0;

0 commit comments

Comments
 (0)