fix: <Ansi/> component has empty links, and clicks bubble up

Author: starpit

package-lock.json

@@ -29,7 +29,6 @@
     "@patternfly/react-table": "4.111.4",
     "anser": "2.1.1",
     "ansi-regex": "6.0.1",
-    "strip-ansi": "6.0.1",
     "html-entities": "2.3.3",
     "madwizard": ">=1.6.4",
     "monaco-editor": "0.34.0",

plugins/plugin-client-common/package.json

@@ -16,7 +16,6 @@
 
 import React from 'react'
 import ansiRegex from 'ansi-regex'
-import stripAnsi from 'strip-ansi'
 import { ansiToJson, AnserJsonEntry } from 'anser'
 
 const Markdown = React.lazy(() => import('../Markdown'))
@@ -45,6 +44,11 @@ function classOf(entry: AnserJsonEntry) {
   return `${fg} ${bg} ${deco.join(' ')}`
 }
 
+/** A stopPropagation onClick event handler */
+function stopProp(evt: React.MouseEvent) {
+  evt.stopPropagation()
+}
+
 function content(source: string) {
   if (/kuiexec/.test(source)) {
     // special case for embedded links; Markdown trims prefix and suffix whitespace
@@ -80,7 +84,12 @@ function content(source: string) {
             if (idx2 >= 0) {
               // the html anchor
               const text = source.slice(start2, idx2)
-              A.push(<a href={stripAnsi(link)}>{text}</a>)
+              const href = link.slice(5, link.length - 1) // `strip-ansi@6.0.1` doesn't seem to work here :(
+              A.push(
+                <a target="_blank" href={href} rel="noreferrer">
+                  {text}
+                </a>
+              )
 
               start = idx2 + tail.length
             }
@@ -93,7 +102,11 @@ function content(source: string) {
         A.push(source.slice(start))
       }
 
-      return <span className="normal-wrap">{A}</span>
+      return (
+        <span onClick={stopProp} className="normal-wrap">
+          {A}
+        </span>
+      )
     }
     return source
   }