fix(plugins/plugin-client-common): sidecar delete button from right split executes command in left split

this is annoying. if i have a table on the left, and a sidecar drilldown on the right, then click the delete button in the sidecar... the delete command is executed on the left, which scrolls my table offscreen. if i'm trying to delete multiple elements, this is annoying

Author: starpit

plugins/plugin-client-common/src/components/Views/Confirm.tsx

@@ -81,6 +81,9 @@ export default class Confirm extends React.PureComponent<Props, State | ActiveSt
     }
   }
 
+  private readonly _onSubmit = this.onConfirm.bind(this, true)
+  private readonly _onClose = this.onConfirm.bind(this, false)
+
   public render() {
     if (!isActive(this.state)) {
       return <React.Fragment />
@@ -93,8 +96,8 @@ export default class Confirm extends React.PureComponent<Props, State | ActiveSt
           title={strings('pleaseConfirm')}
           primaryButtonText={strings('yesIAmSure')}
           secondaryButtonText={strings('cancel')}
-          onSubmit={() => this.onConfirm(true)}
-          onClose={() => this.onConfirm(false)}
+          onSubmit={this._onSubmit}
+          onClose={this._onClose}
         >
           <p className="bx--modal-content__text">{strings('aboutToExecute')}</p>
           <p className="bx--modal-content__text">

plugins/plugin-client-common/src/controller/confirm.ts

@@ -14,15 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  Events,
-  getPrimaryTabId,
-  Registrar,
-  ExecType,
-  UsageModel,
-  i18n,
-  pexecInCurrentTab
-} from '@kui-shell/core'
+import { Events, getPrimaryTabId, Registrar, ExecType, UsageModel, i18n, pexecInCurrentTab } from '@kui-shell/core'
 
 const strings = i18n('plugin-core-support')
 
@@ -65,7 +57,7 @@ export default async (commandTree: Registrar) => {
           if (!confirmed) {
             reject(strings('operationCancelled'))
           } else if (execOptions.type === ExecType.Nested) {
-            pexecInCurrentTab(command).then(resolve, reject)
+            pexecInCurrentTab(command, tab).then(resolve, reject)
           } else {
             REPL.qexec(command, undefined, undefined, { tab }).then(resolve, reject)
           }