Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iss16, 17 #18

Merged
merged 2 commits into from
Jan 17, 2024
Merged

iss16, 17 #18

merged 2 commits into from
Jan 17, 2024

Conversation

TathagataChakraborti
Copy link
Member

@TathagataChakraborti
iss17
dec09a9 
Signed-off-by: Tathagata-Chakraborti1 <tathagata.chakraborti1@ibm.com>
@TathagataChakraborti TathagataChakraborti added bug Something isn't working enhancement New feature or request labels Jan 17, 2024
@TathagataChakraborti TathagataChakraborti self-assigned this Jan 17, 2024
This was linked to issues Jan 17, 2024
Plan comment error #17
Closed
Update to forbiditerative 1.0.8 #16
Closed
@TathagataChakraborti
forbiditerative update
f7dc3c9 
Signed-off-by: Tathagata-Chakraborti1 <tathagata.chakraborti1@ibm.com>
@TathagataChakraborti
Copy link
Member Author

@jkeskingvillage I have changed to the new planner call without the subprocess. 5 tests a failing, check if they are supposed to pass or it's just the planner returning different plans.

jkeskingvillage
jkeskingvillage approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@jkeskingvillage jkeskingvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. Let me fix all the failing tests.

@jkeskingvillage jkeskingvillage merged commit 98b10eb into main Jan 17, 2024
1 check passed
@jkeskingvillage jkeskingvillage deleted the iss16 branch January 17, 2024 22:06
@jkeskingvillage jkeskingvillage mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeskingvillage jkeskingvillage jkeskingvillage approved these changes

Assignees

@TathagataChakraborti TathagataChakraborti

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan comment error Update to forbiditerative 1.0.8
2 participants
@TathagataChakraborti @jkeskingvillage